openstack
/
sahara
Code Issues Proposed changes

Fix some doc and comments nits 

there are few small nits can be fixed.

Sahara imports castellan and barbican to store private info.
so the openstack services comunicated with sahara should
include castellan.

Change-Id: Ib957cd2d8f98d2c1de3a470b5f0790e7c5015d72
This commit is contained in:
Shu Yingya 2017-01-16 19:02:17 +08:00
parent 5490475b69
commit 26810d5c69
4 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/source/overview.rst
View File

@ -69,6 +69,8 @@ The sahara product communicates with the following OpenStack services:
metering and monitoring purposes.
* Shared file systems (manila) - can be used for storage of framework job
binaries and data that will be processed or created by jobs.
* Key manager (barbican & castellan) - persists the authentication data
like passwords and private keys in a secure storage.
.. image:: images/openstack-interop.png
:width: 800 px

2
sahara/service/api/v11.py
View File

@ -109,7 +109,7 @@ def execute_job(job_id, data):
# Since we will use a unified class in the database, we pass
# a superset for all job types
# example configs['start'] = '2015-05-12T08:55Z' frequency = 5 means
# example configs['start'] = '2015-05-12T08:55Z' frequency = 5 mins
# the job will starts from 2015-05-12T08:55Z, runs every 5 mins
job_execution_info = data.get('job_execution_info', {})

2
sahara/service/api/v2/job_executions.py
View File

@ -41,7 +41,7 @@ def execute_job(job_id, data):
# Since we will use a unified class in the database, we pass
# a superset for all job types
# example configs['start'] = '2015-05-12T08:55Z' frequency = 5 means
# example configs['start'] = '2015-05-12T08:55Z' frequency = 5 mins
# the job will starts from 2015-05-12T08:55Z, runs every 5 mins
job_execution_info = data.get('job_execution_info', {})

2
sahara/utils/ssh_remote.py
View File

@ -173,7 +173,7 @@ def _execute_command(cmd, run_as_root=False, get_stderr=False,
else:
chan.exec_command(cmd)
# todo(dmitryme): that could hang if stderr buffer overflows
# TODO(dmitryme): that could hang if stderr buffer overflows
stdout = _read_paramimko_stream(chan.recv)
stderr = _read_paramimko_stream(chan.recv_stderr)