openstack
/
sphinx-feature-classification
Code Issues Proposed changes

Fix the summary table border not rendering 

This patch fixes the summary table border to render properly when
other CSS content uses no border for tables.
It also sets the table font size to medium, improving the space used
by the summary table as well as the look of the table.

Change-Id: I0f2bdee6eb67753f5f365b2681c4c7e3ae35c3ec
This commit is contained in:
Michael Johnson 2019-04-12 16:41:27 -07:00
parent 2dacdfb5bf
commit 9154e61ea9
3 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sphinx_feature_classification/releasenotes/notes/update-summary-table-style-cb5a00eb45cce78a.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
Fixed the summary table border not rendering and improved the table
font sizing.

8
sphinx_feature_classification/support-matrix.css
View File

@ -1,8 +1,12 @@
.sp_feature_required {
font-weight: bold;
}
.sp_feature_cells {
border: solid 1px black;
text-align: center;
}
.sp_impl_complete {
color: rgb(0, 120, 0);
font-weight: normal;
@ -24,7 +28,7 @@
}
.sp_impl_summary {
font-size: 2em;
font-size: medium;
}
.sp_cli {

14
sphinx_feature_classification/support_matrix.py
View File

@ -248,7 +248,7 @@ class Directive(rst.Directive):
"""
summary_title = nodes.subtitle(text="Summary")
summary = nodes.table()
summary = nodes.table(classes=["sp_feature_cells"])
cols = len(matrix.drivers.keys())
# Add two columns for the Feature and Status columns.
@ -269,10 +269,10 @@ class Directive(rst.Directive):
# This sets up all the column headers - two fixed
# columns for feature name & status
header = nodes.row()
blank = nodes.entry()
blank = nodes.entry(classes=["sp_feature_cells"])
blank.append(nodes.emphasis(text="Feature"))
header.append(blank)
blank = nodes.entry()
blank = nodes.entry(classes=["sp_feature_cells"])
blank.append(nodes.emphasis(text="Status"))
header.append(blank)
summary_head.append(header)
@ -282,7 +282,7 @@ class Directive(rst.Directive):
key=lambda x: matrix.drivers[x].title)
for key in impls:
driver = matrix.drivers[key]
implcol = nodes.entry()
implcol = nodes.entry(classes=["sp_feature_cells"])
header.append(implcol)
implcol.append(nodes.strong(text=driver.title))
@ -295,7 +295,7 @@ class Directive(rst.Directive):
feature_id = re.sub(KEY_PATTERN, "_", feature.key)
# first the fixed columns for title/status
key_col = nodes.entry()
key_col = nodes.entry(classes=["sp_feature_cells"])
item.append(key_col)
key_ref = nodes.reference(refid=feature_id)
key_txt = nodes.inline()
@ -303,7 +303,7 @@ class Directive(rst.Directive):
key_txt.append(key_ref)
key_ref.append(nodes.strong(text=feature.title))
status_col = nodes.entry()
status_col = nodes.entry(classes=["sp_feature_cells"])
item.append(status_col)
status_col.append(nodes.inline(
text=feature.status,
@ -312,7 +312,7 @@ class Directive(rst.Directive):
# and then one column for each backend driver
for key in impls:
impl = feature.implementations[key]
impl_col = nodes.entry()
impl_col = nodes.entry(classes=["sp_feature_cells"])
item.append(impl_col)
key_id = re.sub(KEY_PATTERN, "_",