Enable some off-by-default checks
Some of the available checks are disabled by default, like: [H106] Don’t put vim configuration in source files [H203] Use assertIs(Not)None to check for None Change-Id: I380596faf23005e03a9a45f06cade5cb05837fb5
This commit is contained in:
parent
ad0d018fbd
commit
23c9bad3bd
|
@ -222,7 +222,7 @@ class SystemTestCase(base.TestCase):
|
|||
self.sys_inst._parse_attributes()
|
||||
# | THEN |
|
||||
self.assertEqual(96, self.sys_inst.memory_summary.size_gib)
|
||||
self.assertEqual(None, self.sys_inst.memory_summary.health)
|
||||
self.assertIsNone(self.sys_inst.memory_summary.health)
|
||||
|
||||
# | GIVEN |
|
||||
self.sys_inst._json['MemorySummary'].pop('Status')
|
||||
|
@ -230,22 +230,22 @@ class SystemTestCase(base.TestCase):
|
|||
self.sys_inst._parse_attributes()
|
||||
# | THEN |
|
||||
self.assertEqual(96, self.sys_inst.memory_summary.size_gib)
|
||||
self.assertEqual(None, self.sys_inst.memory_summary.health)
|
||||
self.assertIsNone(self.sys_inst.memory_summary.health)
|
||||
|
||||
# | GIVEN |
|
||||
self.sys_inst._json['MemorySummary'].pop('TotalSystemMemoryGiB')
|
||||
# | WHEN |
|
||||
self.sys_inst._parse_attributes()
|
||||
# | THEN |
|
||||
self.assertEqual(None, self.sys_inst.memory_summary.size_gib)
|
||||
self.assertEqual(None, self.sys_inst.memory_summary.health)
|
||||
self.assertIsNone(self.sys_inst.memory_summary.size_gib)
|
||||
self.assertIsNone(self.sys_inst.memory_summary.health)
|
||||
|
||||
# | GIVEN |
|
||||
self.sys_inst._json.pop('MemorySummary')
|
||||
# | WHEN |
|
||||
self.sys_inst._parse_attributes()
|
||||
# | THEN |
|
||||
self.assertEqual(None, self.sys_inst.memory_summary)
|
||||
self.assertIsNone(self.sys_inst.memory_summary)
|
||||
|
||||
def test_processors(self):
|
||||
# check for the underneath variable value
|
||||
|
|
4
tox.ini
4
tox.ini
|
@ -40,8 +40,10 @@ commands = oslo_debug_helper {posargs}
|
|||
|
||||
[flake8]
|
||||
# E123, E125 skipped as they are invalid PEP-8.
|
||||
|
||||
show-source = True
|
||||
ignore = E123,E125
|
||||
# H106: Don’t put vim configuration in source files
|
||||
# H203: Use assertIs(Not)None to check for None
|
||||
enable-extensions=H106,H203
|
||||
builtins = _
|
||||
exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build
|
||||
|
|
Loading…
Reference in New Issue