openstack
/
swift-bench
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 7233 <7233@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 34892 \u003c34892@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_7233\u003e replied on the change"}
This commit is contained in:
Gerrit User 7233 2022-12-06 01:35:46 +00:00 committed by Gerrit Code Review
parent d8aaaddf18
commit f30578bc14
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
943b098b18c07c38d0888827ddd558dd22e6c30c Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "5ee33c35_ada70e77",
"filename": "bin/swift-bench",
"patchSetId": 1
},
"lineNbr": 159,
"author": {
"id": 7233
},
"writtenOn": "2022-12-06T01:35:46Z",
"side": 1,
"message": "Doesn\u0027t this break normal behaviour?\n\nBy default there will be an options.container_name that\u0027s loaded in from the config or DEFAULT config values which is using UUID.\n\nAdding it to the CLI is great, as this will override the config value.\nLook on line 164, when options.num_container is 1, the container_name will be \"\u003coptions.container_name\u003e_1\".\nSo it\u0027s not really container_name but container_name base.\n\nSo I think you need to remove this check as it isn\u0027t required. and change the help string to in line 121 to say something like:\n\n Set the base container_name",
"revId": "943b098b18c07c38d0888827ddd558dd22e6c30c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}