Update patch set 5
Patch Set 5: (6 comments) Patch-set: 5
This commit is contained in:
Gerrit User 36798
Gerrit Code Review
parent
c597e9edb9
commit
5223d9bf66
|
|
@ -34,6 +34,23 @@
|
|||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "4d793db2_98103cbb",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 36798
|
||||
},
|
||||
"writtenOn": "2024-03-13T14:50:07Z",
|
||||
"side": 1,
|
||||
"message": "thanks for your review.",
|
||||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -57,6 +74,30 @@
|
|||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "85ca5f64_25691b7e",
|
||||
"filename": "tacker_horizon/openstack_dashboard/dashboards/nfv/lccnsubscription/panel.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 24,
|
||||
"author": {
|
||||
"id": 36798
|
||||
},
|
||||
"writtenOn": "2024-03-13T14:50:07Z",
|
||||
"side": 1,
|
||||
"message": "I fixed in PatchSet 6 it as you pointed out.",
|
||||
"parentUuid": "97123df2_16f54df8",
|
||||
"range": {
|
||||
"startLine": 24,
|
||||
"startChar": 10,
|
||||
"endLine": 24,
|
||||
"endChar": 11
|
||||
},
|
||||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -80,6 +121,30 @@
|
|||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4e3d802b_be3db623",
|
||||
"filename": "tacker_horizon/openstack_dashboard/dashboards/nfv/vnffmalarm/forms.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 25,
|
||||
"author": {
|
||||
"id": 36798
|
||||
},
|
||||
"writtenOn": "2024-03-13T14:50:07Z",
|
||||
"side": 1,
|
||||
"message": "I revised class name in PatchSet 6.\nAlso the other Class names have been modified as well.",
|
||||
"parentUuid": "e1ec462b_50032970",
|
||||
"range": {
|
||||
"startLine": 25,
|
||||
"startChar": 12,
|
||||
"endLine": 25,
|
||||
"endChar": 22
|
||||
},
|
||||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -103,6 +168,30 @@
|
|||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "89356135_78ea9143",
|
||||
"filename": "tacker_horizon/openstack_dashboard/dashboards/nfv/vnffmalarm/panel.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 24,
|
||||
"author": {
|
||||
"id": 36798
|
||||
},
|
||||
"writtenOn": "2024-03-13T14:50:07Z",
|
||||
"side": 1,
|
||||
"message": "I revised class name in PatchSet 6.\nAlso the other Class names have been modified as well.",
|
||||
"parentUuid": "e44f67f3_93ba6f1a",
|
||||
"range": {
|
||||
"startLine": 24,
|
||||
"startChar": 6,
|
||||
"endLine": 24,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -126,6 +215,30 @@
|
|||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4fe8b5c1_b7f4679f",
|
||||
"filename": "tacker_horizon/openstack_dashboard/dashboards/nfv/vnffmalarm/tables.py",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 22,
|
||||
"author": {
|
||||
"id": 36798
|
||||
},
|
||||
"writtenOn": "2024-03-13T14:50:07Z",
|
||||
"side": 1,
|
||||
"message": "The `MyFilterAction` class was implemented in the legacy tables of other tacker-horizon and I used it as a reference..\nHowever, since it didn\u0027t need to define `MyFilterAction`, so I deleted it and change to set `tables.FilterAction` directly to table_actions in PatchSet 6.",
|
||||
"parentUuid": "1ed7dac4_5604d465",
|
||||
"range": {
|
||||
"startLine": 22,
|
||||
"startChar": 6,
|
||||
"endLine": 22,
|
||||
"endChar": 20
|
||||
},
|
||||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -148,6 +261,30 @@
|
|||
},
|
||||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f900c6b9_c0f01392",
|
||||
"filename": "tacker_horizon/openstack_dashboard/dashboards/nfv/vnfpmthreshold/templates/vnfpmthreshold/pmthreshold_detail.html",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 8,
|
||||
"author": {
|
||||
"id": 36798
|
||||
},
|
||||
"writtenOn": "2024-03-13T14:50:07Z",
|
||||
"side": 1,
|
||||
"message": "I have fixed it, and same fixing is done in other html file in PatchSet 6.",
|
||||
"parentUuid": "5b803270_bd9013ee",
|
||||
"range": {
|
||||
"startLine": 8,
|
||||
"startChar": 36,
|
||||
"endLine": 8,
|
||||
"endChar": 37
|
||||
},
|
||||
"revId": "b3813f31d09287e83299d9bd8bb43e958e656800",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue