From 23ed3141a3b3b6cb18919aea4ef8e0badf4e3b0d Mon Sep 17 00:00:00 2001
From: Tony Breeds <tony@bakeyournoodle.com>
Date: Wed, 21 Dec 2016 13:44:50 +1100
Subject: [PATCH] Add Constraints support

Adding constraints support to libraries is slightly more complex than
services as the libraries themselves are listed in upper-constraints.txt
which leads to errors that you can't install a specific version and a
constrained version.

This change adds constraints support by also adding a helper script to
edit the constraints to remove taskflow.

(cherry picked from commit 09ded16b22a03c44d907db965d4a376a132b8030)

Change-Id: Ic765cb6979d45d32aa36db42861ef5f3b5666cac
---
 tools/tox_install.sh | 30 ++++++++++++++++++++++++++++++
 tox.ini              |  7 +++++--
 2 files changed, 35 insertions(+), 2 deletions(-)
 create mode 100755 tools/tox_install.sh

diff --git a/tools/tox_install.sh b/tools/tox_install.sh
new file mode 100755
index 000000000..e61b63a8b
--- /dev/null
+++ b/tools/tox_install.sh
@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+
+# Client constraint file contains this client version pin that is in conflict
+# with installing the client from source. We should remove the version pin in
+# the constraints file before applying it for from-source installation.
+
+CONSTRAINTS_FILE="$1"
+shift 1
+
+set -e
+
+# NOTE(tonyb): Place this in the tox enviroment's log dir so it will get
+# published to logs.openstack.org for easy debugging.
+localfile="$VIRTUAL_ENV/log/upper-constraints.txt"
+
+if [[ "$CONSTRAINTS_FILE" != http* ]]; then
+    CONSTRAINTS_FILE="file://$CONSTRAINTS_FILE"
+fi
+# NOTE(tonyb): need to add curl to bindep.txt if the project supports bindep
+curl "$CONSTRAINTS_FILE" --insecure --progress-bar --output "$localfile"
+
+pip install -c"$localfile" openstack-requirements
+
+# This is the main purpose of the script: Allow local installation of
+# the current repo. It is listed in constraints file and thus any
+# install will be constrained and we need to unconstrain it.
+edit-constraints "$localfile" -- "$CLIENT_NAME"
+
+pip install -c"$localfile" -U "$@"
+exit $?
diff --git a/tox.ini b/tox.ini
index 90f31d57d..9c77dd50c 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,5 +1,5 @@
 [tox]
-minversion = 1.6
+minversion = 2.0
 envlist = cover,
     docs,
     pep8,
@@ -10,6 +10,10 @@ envlist = cover,
     update-states
 
 [testenv]
+setenv = VIRTUAL_ENV={envdir}
+         BRANCH_NAME=stable/newton
+         CLIENT_NAME=taskflow
+install_command = {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=stable/newton} {opts} {packages}
 # We need to install a bit more than just `test' because those drivers have
 # custom tests that we always run
 deps = .[test,workers,zookeeper,database,redis,eventlet,doc]
@@ -28,7 +32,6 @@ commands = {toxinidir}/tools/update_states.sh
 commands = flake8 {posargs}
 
 [testenv:pylint]
-setenv = VIRTUAL_ENV={envdir}
 deps = {[testenv]deps}
     pylint==0.26.0
 commands = pylint --rcfile=pylintrc taskflow