From dbca28c411ba3a2db704604bf2b1b2048f520248 Mon Sep 17 00:00:00 2001
From: Ronelle Landy <rlandy@redhat.com>
Date: Tue, 15 May 2018 13:41:15 -0400
Subject: [PATCH] Add linter jobs for releases file script

This review adds a pep8 jobs to be triggered
with changes to the releases script files.
pylint was considered but removed from this
initial review.

Change-Id: Ib8809c94d99ccb1ecafa94b3791f613c35dbd9ef
---
 scripts/emit_releases_file/emit_releases_file.py | 1 +
 scripts/emit_releases_file/test_get_dlrn_hash.py | 1 +
 tox.ini                                          | 3 ++-
 zuul.d/layout.yaml                               | 6 ++++++
 4 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/scripts/emit_releases_file/emit_releases_file.py b/scripts/emit_releases_file/emit_releases_file.py
index 7efe7a7ed..f18f417f3 100644
--- a/scripts/emit_releases_file/emit_releases_file.py
+++ b/scripts/emit_releases_file/emit_releases_file.py
@@ -8,6 +8,7 @@ import yaml
 
 # Define releases
 RELEASES = ['newton', 'ocata', 'pike', 'queens', 'master']
+# Define long term releases
 LONG_TERM_SUPPORT_RELEASES = ['queens']
 
 
diff --git a/scripts/emit_releases_file/test_get_dlrn_hash.py b/scripts/emit_releases_file/test_get_dlrn_hash.py
index 59a6e37b6..2525fb190 100644
--- a/scripts/emit_releases_file/test_get_dlrn_hash.py
+++ b/scripts/emit_releases_file/test_get_dlrn_hash.py
@@ -3,6 +3,7 @@ from emit_releases_file import get_dlrn_hash
 import mock
 import pytest
 
+
 @mock.patch('requests.get')
 def test_get_dlrn_hash(mock_get):
     mock_response = mock.Mock()
diff --git a/tox.ini b/tox.ini
index d4daa14a3..1f561f20d 100644
--- a/tox.ini
+++ b/tox.ini
@@ -15,8 +15,9 @@ deps = pyflakes
 commands = pyflakes setup.py scripts
 
 [testenv:pep8]
+changedir = scripts/emit_releases_file
 whitelist_externals = bash
-commands = flake8
+commands = flake8 --max-line-length 80
 
 [testenv:cireport]
 passenv =
diff --git a/zuul.d/layout.yaml b/zuul.d/layout.yaml
index 176bf3c1a..dd4762c7e 100644
--- a/zuul.d/layout.yaml
+++ b/zuul.d/layout.yaml
@@ -18,6 +18,9 @@
         - openstack-tox-py35:
             files:
               - ^scripts/emit_releases_file/.*$
+        - openstack-tox-pep8:
+            files:
+              - ^scripts/emit_releases_file/.*$
     gate:
       queue: tripleo
       jobs:
@@ -27,3 +30,6 @@
         - openstack-tox-py35:
             files:
               - ^scripts/emit_releases_file/.*$
+        - openstack-tox-pep8:
+            files:
+              - ^scripts/emit_releases_file/.*$