From f7a06b637cb3317660e7b228f2a7f068727e39e6 Mon Sep 17 00:00:00 2001
From: Chandan Kumar <chkumar@redhat.com>
Date: Fri, 26 Oct 2018 16:53:35 +0530
Subject: [PATCH] Move tempest overrides to var at task level

* In run-v3.yaml, we have started adding tempest overrides in a list
  and it started growing which is hard to handle so we can move to
  a var with list and re-use that and it also improves the
  readability.

Change-Id: Icde2989122889be426309c36a912163f69398190
---
 playbooks/tripleo-ci/run-v3.yaml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/playbooks/tripleo-ci/run-v3.yaml b/playbooks/tripleo-ci/run-v3.yaml
index e5ca061c1..c7c0694fc 100644
--- a/playbooks/tripleo-ci/run-v3.yaml
+++ b/playbooks/tripleo-ci/run-v3.yaml
@@ -52,9 +52,17 @@
   tasks:
     - block:
       - name: Check overridable settings
+        vars:
+          tempest_overrides:
+            - 'run_tempest'
+            - 'tempest_whitelist'
+            - 'test_black_regex'
+            - 'tempest_format'
+            - 'tempest_extra_config'
+            - 'tempest_plugins'
         fail:
           msg: "ERROR: {{ item }} is not overridable."
-        when: item not in ['run_tempest', 'tempest_whitelist', 'test_black_regex', 'tempest_format', 'tempest_extra_config', 'tempest_plugins']
+        when: item not in "{{ tempest_overrides }}"
         with_items: "{{ featureset_override }}"
       - name: Generate featureset overriding file
         template: