Fix class constructors

Some constructor methods were missing the super call to the parent
class. This change adds the missing calls.

Some constructor methods only had the super calls to the parent class,
which makes them redundant. This change removes those methods.

Change-Id: I3bdda1a1f1bcfa19d166b994d3d3ae2218b95c43

tripleo_common/actions/deployment.py

@@ -191,6 +191,7 @@ class OvercloudRcAction(base.TripleOAction):
     """
 
     def __init__(self, container, no_proxy=""):
+        super(OvercloudRcAction, self).__init__()
         self.container = container
         self.no_proxy = no_proxy
 

tripleo_common/actions/parameters.py

@@ -143,6 +143,7 @@ class GeneratePasswordsAction(base.TripleOAction):
     """
 
     def __init__(self, container=constants.DEFAULT_CONTAINER_NAME):
+        super(GeneratePasswordsAction, self).__init__()
         self.container = container
 
     def run(self):
@@ -193,6 +194,7 @@ class GetPasswordsAction(base.TripleOAction):
     """
 
     def __init__(self, container=constants.DEFAULT_CONTAINER_NAME):
+        super(GetPasswordsAction, self).__init__()
         self.container = container
 
     def run(self):

tripleo_common/actions/plan.py

@@ -192,9 +192,6 @@ class ListPlansAction(base.TripleOAction):
     name as the container.
     """
 
-    def __init__(self):
-        super(ListPlansAction, self).__init__()
-
     def run(self):
         # plans consist of a container object and mistral environment
         # with the same name.  The container is marked with metadata

tripleo_common/actions/validations.py

@@ -26,8 +26,6 @@ from tripleo_common.utils import validations as utils
 
 
 class GetPubkeyAction(base.TripleOAction):
-    def __init__(self):
-        super(GetPubkeyAction, self).__init__()
 
     def run(self):
         mc = self.get_workflow_client()
@@ -63,9 +61,6 @@ class GetPubkeyAction(base.TripleOAction):
 class Enabled(base.TripleOAction):
     """Indicate whether the validations have been enabled."""
 
-    def __init__(self):
-        super(Enabled, self).__init__()
-
     def _validations_enabled(self):
         """Detect whether the validations are enabled on the undercloud."""
         mistral = self.get_workflow_client()
@@ -102,8 +97,6 @@ class ListValidationsAction(base.TripleOAction):
 
 class ListGroupsAction(base.TripleOAction):
     """Return a set of TripleO validation groups"""
-    def __init__(self):
-        super(ListGroupsAction, self).__init__()
 
     def run(self):
         validations = utils.load_validations()