From 29d5b5aa8fed35b35a327fc44de1db15a871b8db Mon Sep 17 00:00:00 2001 From: Ryan Brady Date: Wed, 14 Feb 2018 19:28:05 -0500 Subject: [PATCH] Deprecates tripleo.roles.list action The tripleo.roles.list action is deprecated. Please use the tripleo.plan_management.v1.list_roles workflow instead. Calling actions directly is no longer supported. This patch adds a deprecation notice to the action code, the file where the action is registered and an associated release note. Change-Id: I233be93b5a22008fbbfae8a49f24c3a79b9e2df2 --- .../notes/deprecate-list-roles-action-12744cee0e6d70e5.yaml | 6 ++++++ setup.cfg | 4 ++-- tripleo_common/actions/plan.py | 2 ++ 3 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/deprecate-list-roles-action-12744cee0e6d70e5.yaml diff --git a/releasenotes/notes/deprecate-list-roles-action-12744cee0e6d70e5.yaml b/releasenotes/notes/deprecate-list-roles-action-12744cee0e6d70e5.yaml new file mode 100644 index 000000000..2ca015332 --- /dev/null +++ b/releasenotes/notes/deprecate-list-roles-action-12744cee0e6d70e5.yaml @@ -0,0 +1,6 @@ +--- +deprecations: + - | + The tripleo.roles.list action is deprecated. Please use the + tripleo.plan_management.v1.list_roles workflow instead. Calling actions + directly is no longer supported. diff --git a/setup.cfg b/setup.cfg index 5a4d7f749..1bd38ae82 100644 --- a/setup.cfg +++ b/setup.cfg @@ -119,7 +119,6 @@ mistral.actions = tripleo.logging_to_swift.format_messages = tripleo_common.actions.logging_to_swift:FormatMessagesAction tripleo.logging_to_swift.publish_ui_log_to_swift = tripleo_common.actions.logging_to_swift:PublishUILogToSwiftAction tripleo.logging_to_swift.prepare_log_download = tripleo_common.actions.logging_to_swift:PrepareLogDownloadAction - tripleo.role.list = tripleo_common.actions.plan:ListRolesAction tripleo.scale.delete_node = tripleo_common.actions.scale:ScaleDownAction tripleo.swift.tempurl = tripleo_common.actions.swifthelper:SwiftTempUrlAction tripleo.swift.swift_information = tripleo_common.actions.swifthelper:SwiftInformationAction @@ -151,4 +150,5 @@ mistral.actions = tripleo.ansible = tripleo_common.actions.ansible:AnsibleAction tripleo.ansible-playbook = tripleo_common.actions.ansible:AnsiblePlaybookAction tripleo.templates.upload_default = tripleo_common.actions.templates:UploadTemplatesAction - + # deprecated for rocky release, will be removed in the "S" cycle + tripleo.role.list = tripleo_common.actions.plan:ListRolesAction diff --git a/tripleo_common/actions/plan.py b/tripleo_common/actions/plan.py index 55c9cecb1..1b096afa0 100644 --- a/tripleo_common/actions/plan.py +++ b/tripleo_common/actions/plan.py @@ -137,6 +137,8 @@ class DeletePlanAction(base.TripleOAction): class ListRolesAction(base.TripleOAction): """Returns a deployment plan's roles + DEPRECATED, please use tripleo.plan_management.v1.list_roles workflow + Parses roles_data.yaml and returns the names of all available roles. :param container: name of the Swift container / plan name