From c1dad1ced1fffe3c8e8ec727fc81ccb601b61b8a Mon Sep 17 00:00:00 2001 From: Emilien Macchi Date: Tue, 16 Jun 2020 13:46:21 -0400 Subject: [PATCH] Add tripleo_states to default callback whitelist tripleo_states will be a useful callback to print out informations about a deployment state (e.g. if a node failed but was ignored because of max_failed_percentage). Depends-On: https://review.opendev.org/735962 Change-Id: I82f4945bf1178fad1ff511c994518008f308d12e --- tripleo_common/actions/ansible.py | 5 +++-- tripleo_common/tests/actions/test_ansible.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tripleo_common/actions/ansible.py b/tripleo_common/actions/ansible.py index 095f39e9a..001c41aa9 100644 --- a/tripleo_common/actions/ansible.py +++ b/tripleo_common/actions/ansible.py @@ -60,7 +60,8 @@ def write_default_ansible_cfg(work_dir, '/usr/share/ansible/tripleo-plugins/callback:' '/usr/share/ansible/plugins/callback:' '%s/callback_plugins' % constants.DEFAULT_VALIDATIONS_BASEDIR) - callbacks_whitelist = ','.join(['tripleo_dense', 'tripleo_profile_tasks']) + callbacks_whitelist = ','.join(['tripleo_dense', 'tripleo_profile_tasks', + 'tripleo_states']) action_plugins_path = ( '~/.ansible/plugins/action:' '/usr/share/ansible/plugins/action:' @@ -420,7 +421,7 @@ class AnsiblePlaybookAction(base.TripleOAction): # the whitelist could be collected from multiple # arguments if we find a use case for it 'ANSIBLE_CALLBACK_WHITELIST': - 'tripleo_dense,tripleo_profile_tasks', + 'tripleo_dense,tripleo_profile_tasks,tripleo_states', 'ANSIBLE_STDOUT_CALLBACK': 'tripleo_dense', 'PROFILE_TASKS_TASK_OUTPUT_LIMIT': six.text_type(self.profile_tasks_limit), diff --git a/tripleo_common/tests/actions/test_ansible.py b/tripleo_common/tests/actions/test_ansible.py index 5193f5b37..2fac74a06 100644 --- a/tripleo_common/tests/actions/test_ansible.py +++ b/tripleo_common/tests/actions/test_ansible.py @@ -72,7 +72,7 @@ class AnsiblePlaybookActionTest(base.TestCase): 'ANSIBLE_LOCAL_TEMP': action.work_dir, 'ANSIBLE_CONFIG': ansible_config_path, 'ANSIBLE_CALLBACK_WHITELIST': - 'tripleo_dense,tripleo_profile_tasks', + 'tripleo_dense,tripleo_profile_tasks,tripleo_states', 'ANSIBLE_STDOUT_CALLBACK': 'tripleo_dense', 'PROFILE_TASKS_TASK_OUTPUT_LIMIT': '20', }