From 5446279919d8bf02d542b3a67c259389841aac1d Mon Sep 17 00:00:00 2001
From: Rabi Mishra <ramishra@redhat.com>
Date: Thu, 6 Aug 2020 10:32:39 +0530
Subject: [PATCH] Remove check for ./puppet/services when filtering services

It is no longer a way to indentify if a service is containerized
or not. If the service exists in overcloud_containers.yaml.j2,
it's assumed to be containerized.

Also flips logic to not loop through all services in
resource_regstry.

Change-Id: I25fcf887044fdf4d05d5d4cfa268aab6aebdf244
(cherry picked from commit fbb6b57a272cff26b03d8126a20220e6ca509784)
---
 tripleo_common/image/kolla_builder.py           | 17 +++++------------
 .../tests/image/test_kolla_builder.py           |  3 +--
 2 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/tripleo_common/image/kolla_builder.py b/tripleo_common/image/kolla_builder.py
index cdd58f5e9..a81397bc8 100644
--- a/tripleo_common/image/kolla_builder.py
+++ b/tripleo_common/image/kolla_builder.py
@@ -100,18 +100,11 @@ def build_service_filter(environment, roles_data):
         return None
     enabled_services = get_enabled_services(environment, roles_data)
     resource_registry = environment.get('resource_registry')
-    if not resource_registry:
-        # no way to tell which services are non-containerized, so
-        # filter by enabled services
-        return enabled_services
-
-    for service, env_path in environment.get('resource_registry', {}).items():
-        if service not in enabled_services:
-            continue
-        if env_path == 'OS::Heat::None':
-            enabled_services.remove(service)
-        if '/puppet/services' in env_path:
-            enabled_services.remove(service)
+    if resource_registry:
+        for service in enabled_services.copy():
+            env_path = resource_registry.get(service)
+            if env_path == 'OS::Heat::None':
+                enabled_services.remove(service)
 
     return enabled_services
 
diff --git a/tripleo_common/tests/image/test_kolla_builder.py b/tripleo_common/tests/image/test_kolla_builder.py
index b7050a0c4..e7b317161 100644
--- a/tripleo_common/tests/image/test_kolla_builder.py
+++ b/tripleo_common/tests/image/test_kolla_builder.py
@@ -880,13 +880,12 @@ class TestPrepare(base.TestCase):
                 'OS::TripleO::Services::HeatApi',
                 'OS::TripleO::Services::NovaApi',
                 'OS::TripleO::Services::NovaCompute',
+                'OS::TripleO::Services::NeutronApi',
                 'OS::TripleO::Services::Kubernetes::Worker',
                 'OS::TripleO::Services::SkydiveAgent',
             ]),
             kb.build_service_filter({
                 'resource_registry': {
-                    'OS::TripleO::Services::NeutronApi':
-                    '/tht/puppet/services/foo.yaml',
                     'OS::TripleO::Services::NovaApi':
                     '/tht/docker/services/foo.yaml',
                     'OS::TripleO::Services::NovaCompute':