openstack
/
tripleo-common
Code Issues Proposed changes

Only update parameters once in backup workflow 

In the swift backup workflow we create 2 parameters for temp URLs, but
we don't need to call parameters.update twice, just once with the two
new parameters.

Change-Id: I75b64dca102a62c06c56327cf425451ae804e3b9
This commit is contained in:
Thomas Herve 2018-12-06 12:17:56 +01:00
parent 56a38afa1a
commit e07dc79693
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
workbooks/swift_backup.yaml
View File

@ -26,33 +26,26 @@ workflows:
get_tempurl:
action: tripleo.swift.tempurl
on-success: set_get_tempurl
on-success: put_tempurl
input:
container: <% $.swift_container %>
obj: <% $.swift_tar %>
set_get_tempurl:
action: tripleo.parameters.update
input:
parameters: <% {$.get_url_parm => task(get_tempurl).result} %>
container: <% $.container %>
on-success: put_tempurl
put_tempurl:
action: tripleo.swift.tempurl
on-success: set_put_tempurl
on-success: set_tempurl
input:
container: <% $.swift_container %>
obj: <% $.swift_tar %>
method: "PUT"
set_put_tempurl:
set_tempurl:
action: tripleo.parameters.update
input:
parameters: <% {$.put_url_parm => task(put_tempurl).result} %>
parameters: <% {$.get_url_parm => task(get_tempurl).result, $.put_url_parm => task(put_tempurl).result} %>
container: <% $.container %>
on-success: set_status_success
on-error: set_put_tempurl_failed
on-error: set_tempurl_failed
set_status_success:
on-success: notify_zaqar
@ -60,11 +53,11 @@ workflows:
status: SUCCESS
message: 'Temporary Swift GET/PUT URL parameters have successfully been updated.'
set_put_tempurl_failed:
set_tempurl_failed:
on-success: notify_zaqar
publish:
status: FAILED
message: <% task(set_put_tempurl).result %>
message: <% task(set_tempurl).result %>
notify_zaqar:
workflow: tripleo.messaging.v1.send