Enable package installation by default

Now overcloud is always deployed using pre-provisioned nodes, and all
deployment types(standalone, undercloud and overcloud) enables package
installation.

Thus we can update the default value of EnablePackageInstall instead of
setting the parameter everytime.

Change-Id: I5598f6d8ee82f0df2598dd0e48fbc16cdb426009

deployment/octavia/octavia-worker-container-puppet.yaml

@@ -43,7 +43,7 @@ parameters:
     description: Parameters specific to the role
     type: json
   EnablePackageInstall:
-    default: 'false'
+    default: true
     description: Set to true to enable package installation at deploy time
     type: boolean
   MonitoringSubscriptionOctaviaWorker:

deployment/timemaster/timemaster-baremetal-ansible.yaml

@@ -79,7 +79,7 @@ parameters:
     constraints:
       - range: { min: 4, max: 17 }
   EnablePackageInstall:
-    default: 'false'
+    default: true
     description: Set to true to enable package installation at deploy time
     type: boolean
   ChronyAclRules:

deployment/timesync/chrony-baremetal-ansible.yaml

@@ -79,7 +79,7 @@ parameters:
     constraints:
       - range: { min: 4, max: 17 }
   EnablePackageInstall:
-    default: 'false'
+    default: true
     description: Set to true to enable package installation at deploy time
     type: boolean
   ChronyAclRules:

deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml

@@ -28,7 +28,7 @@ parameters:
                  via parameter_defaults in the resource registry.
     type: json
   EnablePackageInstall:
-    default: 'false'
+    default: true
     description: Set to true to enable package installation at deploy time
     type: boolean
   UpgradeLeappEnabled:

environments/deployed-server-environment.j2.yaml

@@ -2,7 +2,6 @@ resource_registry:
   OS::TripleO::DeployedServer::ControlPlanePort: OS::Neutron::Port
 
 parameter_defaults:
-  EnablePackageInstall: True
 {% for role in roles %}
   {{role.name}}NetworkConfigTemplate: 'templates/net_config_static_bridge.j2'
 {% endfor %}

environments/lifecycle/upgrade-prepare.yaml

@@ -9,7 +9,6 @@ resource_registry:
 
 parameter_defaults:
   CephAnsiblePlaybook: default
-  EnablePackageInstall: true
   ServerDeletionPolicy: retain
   UpgradeLevelNovaCompute: auto
   UpgradeLeappToRemove: ['openvswitch2.11','ovn2.11']

environments/standalone/standalone-tripleo.yaml

@@ -32,10 +32,6 @@ parameter_defaults:
   # Type: comma_delimited_list
   DnsServers: []
 
-  # Set to true to enable package installation at deploy time
-  # Type: boolean
-  EnablePackageInstall: True
-
   # Allow to enable/disable safe networking defaults if os-net-config would fail to run with the provided config.
   # Type: boolean
   NetworkSafeDefaults: True

environments/undercloud.yaml

@@ -51,7 +51,6 @@ parameter_defaults:
   # ensure we enable ip_forward before docker gets run
   KernelIpForward: 1
   KernelIpNonLocalBind: 1
-  EnablePackageInstall: true
   UndercloudNetworkConfigUpdate: True
   NeutronTunnelTypes: []
   NeutronBridgeMappings: ctlplane:br-ctlplane

overcloud-resource-registry-puppet.j2.yaml

@@ -335,7 +335,7 @@ parameter_merge_strategies:
 parameter_defaults:
   NeutronMechanismDrivers: ovn
   ContainerCli: podman
-  EnablePackageInstall: false
+  EnablePackageInstall: true
   SoftwareConfigTransport: POLL_SERVER_HEAT
   OVNIntegrationBridge: br-int
   ExtraConfig: {}

sample-env-generator/standalone.yaml

@@ -31,9 +31,6 @@ environments:
       deployment/timesync/chrony-baremetal-ansible.yaml:
         parameters:
           - NtpServer
-      deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml:
-        parameters:
-          - EnablePackageInstall
       deployment/sshd/sshd-baremetal-ansible.yaml:
         parameters:
           - SshFirewallAllowAll
@@ -47,7 +44,6 @@ environments:
           - DnsServers
     sample_values:
       AddVipsToEtcHosts: false
-      EnablePackageInstall: true
       SwiftReplicas: 1
       SshFirewallAllowAll: true
       StandaloneNetworkConfigTemplate: templates/standalone.j2