Fix invalid Ceph and BlockStorage role template

The roles would get generated with deprecated parameter group, but no
parameter in that group. Heat would then refuse that template.

Change-Id: I526c8177d1a759ae9e48cdb8b94fc2aa7fe3c6fb
Closes-Bug: #1750828

puppet/role.role.j2.yaml

@@ -237,7 +237,7 @@ parameters:
       Name of the subnet on ctlplane network for this role.
     type: string
 
-{% if role.uses_deprecated_params is defined %}
+{% if role.uses_deprecated_params|default(false) %}
 parameter_groups:
 - label: deprecated
   description: Do not use deprecated params, they will be removed.

roles/BlockStorage.yaml

@@ -8,7 +8,7 @@
     - InternalApi
     - Storage
     - StorageMgmt
-  uses_deprecated_params: True
+  uses_deprecated_params: False
   deprecated_nic_config_name: 'cinder-storage.yaml'
   ServicesDefault:
     - OS::TripleO::Services::Aide

roles/CephStorage.yaml

@@ -7,7 +7,7 @@
   networks:
     - Storage
     - StorageMgmt
-  uses_deprecated_params: True
+  uses_deprecated_params: False
   deprecated_nic_config_name: 'ceph-storage.yaml'
   ServicesDefault:
     - OS::TripleO::Services::Aide

roles_data.yaml

@@ -247,7 +247,7 @@
     - InternalApi
     - Storage
     - StorageMgmt
-  uses_deprecated_params: True
+  uses_deprecated_params: False
   deprecated_nic_config_name: 'cinder-storage.yaml'
   ServicesDefault:
     - OS::TripleO::Services::Aide
@@ -332,7 +332,7 @@
   networks:
     - Storage
     - StorageMgmt
-  uses_deprecated_params: True
+  uses_deprecated_params: False
   deprecated_nic_config_name: 'ceph-storage.yaml'
   ServicesDefault:
     - OS::TripleO::Services::Aide