Add constraints to service Debug flags

The service debug flags (e.g. BarbicanDebug), allow the deployer to set
the verbose logging for a specific service. They are strings to allow
folks to set it up regardless of the global Debug flag being set.

This commit adds a constraint to set the allowed values for these
parameters. It is based on a subset of the underlying implementation
that sets this flag (which uses any2bool).

Change-Id: I35e7a7ee35aefb7108ec6b0bb8f3124610fb97ee

puppet/services/aodh-base.yaml

@@ -64,6 +64,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Aodh services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   KeystoneRegion:
     type: string
     default: 'regionOne'

puppet/services/barbican-api.yaml

@@ -46,6 +46,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Barbican service.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   KeystoneRegion:
     type: string
     default: 'regionOne'

puppet/services/ceilometer-base.yaml

@@ -74,6 +74,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Ceilometer services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   KeystoneRegion:
     type: string
     default: 'regionOne'

puppet/services/cinder-base.yaml

@@ -16,6 +16,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging on Cinder services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   ServiceData:
     default: {}
     description: Dictionary packing service data

puppet/services/congress.yaml

@@ -42,6 +42,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Glance service.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   KeystoneRegion:
     type: string
     default: 'regionOne'

puppet/services/glance-api.yaml

@@ -38,6 +38,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Glance service.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   GlancePassword:
     description: The password for the glance service and db account, used by the glance services.
     type: string

puppet/services/gnocchi-base.yaml

@@ -64,6 +64,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Gnocchi services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   GnocchiStorageSwiftEndpointType:
     default: 'internalURL'
     description: Set to modify which endpoint type is gnocchi accessing swift

puppet/services/heat-base.yaml

@@ -12,6 +12,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Heat services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   RabbitPassword:
     description: The password for RabbitMQ
     type: string

puppet/services/horizon.yaml

@@ -22,6 +22,8 @@ parameters:
     default: false
     description: Set to True to enable debugging Horizon service.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   DefaultPasswords:
     default: {}
     type: json

puppet/services/ironic-base.yaml

@@ -38,6 +38,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Ironic services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   IronicPassword:
     description: The password for the Ironic service and db account, used by the Ironic services
     type: string

puppet/services/keystone.yaml

@@ -72,6 +72,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Keystone service.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   AdminEmail:
     default: 'admin@example.com'
     description: The email for the keystone admin account.

puppet/services/manila-base.yaml

@@ -38,6 +38,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Manila services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   RabbitPassword:
     description: The password for RabbitMQ
     type: string

puppet/services/memcached.yaml

@@ -47,6 +47,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Memcached service.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
 
 conditions:
   service_debug:

puppet/services/mistral-base.yaml

@@ -39,6 +39,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Mistral services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   RabbitPassword:
     description: The password for RabbitMQ
     type: string

puppet/services/neutron-base.yaml

@@ -58,6 +58,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Neutron services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   EnableConfigPurge:
     type: boolean
     default: false

puppet/services/nova-base.yaml

@@ -82,6 +82,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Nova services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   EnableConfigPurge:
     type: boolean
     default: false

puppet/services/octavia-base.yaml

@@ -38,6 +38,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Octavia services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   EnableConfigPurge:
     type: boolean
     default: false

puppet/services/panko-base.yaml

@@ -42,6 +42,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Panko services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   KeystoneRegion:
     type: string
     default: 'regionOne'

puppet/services/sahara-base.yaml

@@ -60,6 +60,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Sahara services.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   SaharaPlugins:
     default: ["ambari","cdh","mapr","vanilla","spark","storm"]
     description: Sahara enabled plugin list

puppet/services/tacker.yaml

@@ -42,6 +42,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Tacker service.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   KeystoneRegion:
     type: string
     default: 'regionOne'

puppet/services/zaqar-api.yaml

@@ -38,6 +38,8 @@ parameters:
     default: ''
     description: Set to True to enable debugging Zaqar service.
     type: string
+    constraints:
+      - allowed_values: [ '', 'true', 'True', 'TRUE', 'false', 'False', 'FALSE']
   ZaqarPassword:
     description: The password for Zaqar
     type: string