Fix nCipher (aka thales) ansible role name

This patch fixes the role name used to run the ansible
role that configures nCipher (aka thales) HSM device when
Barbican is deployed with that backend.

The role was renamed from 'thales-hsm' to 'thales_hsm' [1]
but a couple of references were missed, which break the
deployment when using an nCipher device.

[1] https://review.opendev.org/#/c/724414

Change-Id: Ia9209cb4a781375577480c175126321515e7af7c
(cherry picked from commit 8c358e2e7c)

deployment/barbican/barbican-api-container-puppet.yaml

@@ -101,7 +101,7 @@ parameters:
     default: 'internal_api'
   ThalesVars:
     default: {}
-    description: Hash of thales-hsm role variables used to
+    description: Hash of thales_hsm role variables used to
                  install Thales client software.
     type: json
   ATOSVars:
@@ -428,7 +428,7 @@ outputs:
                         thales_hsm_config_location: "{{thales_hsm_config_location}}"
                         thales_bootstrap_client_ip: "{{thales_bootstrap_client_ip}}"
                       roles:
-                        - thales-hsm
+                        - thales_hsm
 
               - name: call ansible on rfs server
                 shell: ANSIBLE_HOST_KEY_CHECKING=False ansible-playbook -i "{{thales_rfs_inventory}}" --key-file "{{thales_rfs_keyfile}}" --ssh-extra-args "-o StrictHostKeyChecking=no" "{{thales_rfs_playbook}}"