From 6d194bc93086c4f46f75cd78b756da6e107e084f Mon Sep 17 00:00:00 2001
From: Martin Magr <mmagr@redhat.com>
Date: Tue, 10 Mar 2020 17:39:05 +0100
Subject: [PATCH] [TRAIN-ONLY] Finish Ceilometer-Panko decouple

Currently it is still not possible to deploy Ceilometer notification agent without Panko.
This patch is fixing this issue.

Change-Id: Iac9e3e173b124d711886087ccbc7593afc13a87c
---
 ...r-agent-notification-container-puppet.yaml | 40 +++++++++++--------
 .../metrics/ceilometer-write-qdr.yaml         |  1 +
 2 files changed, 25 insertions(+), 16 deletions(-)

diff --git a/deployment/ceilometer/ceilometer-agent-notification-container-puppet.yaml b/deployment/ceilometer/ceilometer-agent-notification-container-puppet.yaml
index f9979aa132..920b48ad7f 100644
--- a/deployment/ceilometer/ceilometer-agent-notification-container-puppet.yaml
+++ b/deployment/ceilometer/ceilometer-agent-notification-container-puppet.yaml
@@ -90,25 +90,29 @@ outputs:
         config_image: {get_param: ContainerCeilometerConfigImage}
       kolla_config:
         /var/lib/kolla/config_files/ceilometer_agent_notification.json:
-          command: /usr/bin/ceilometer-agent-notification --logfile /var/log/ceilometer/agent-notification.log
-          config_files:
-            list_concat:
-              - - source: "/var/lib/kolla/config_files/src/*"
-                  dest: "/"
-                  merge: true
-                  preserve_properties: true
-              - if:
-                  - ceilometer_enable_panko
-                  - - source: "/var/lib/kolla/config_files/src-panko/*"
+          map_merge:
+            - command: /usr/bin/ceilometer-agent-notification --logfile /var/log/ceilometer/agent-notification.log
+              config_files:
+                list_concat:
+                  - - source: "/var/lib/kolla/config_files/src/*"
                       dest: "/"
                       merge: true
                       preserve_properties: true
-                  - null
+                  - if:
+                      - ceilometer_enable_panko
+                      - - source: "/var/lib/kolla/config_files/src-panko/*"
+                          dest: "/"
+                          merge: true
+                          preserve_properties: true
+                      - null
+            - if:
+              - ceilometer_enable_panko
+              - permissions:
+                  - path: /etc/panko
+                    owner: root:ceilometer
+                    recurse: true
+              - {}
 
-          permissions:
-            - path: /etc/panko
-              owner: root:ceilometer
-              recurse: true
       docker_config:
         step_3:
           ceilometer_init_log:
@@ -132,8 +136,12 @@ outputs:
                 -
                   - /var/lib/kolla/config_files/ceilometer_agent_notification.json:/var/lib/kolla/config_files/config.json:ro
                   - /var/lib/config-data/puppet-generated/ceilometer:/var/lib/kolla/config_files/src:ro
-                  - /var/lib/config-data/puppet-generated/panko:/var/lib/kolla/config_files/src-panko:ro
                   - /var/log/containers/ceilometer:/var/log/ceilometer:z
+                - if:
+                  - ceilometer_enable_panko
+                  - - /var/lib/config-data/puppet-generated/panko:/var/lib/kolla/config_files/src-panko:ro
+                  - []
+
             environment:
               KOLLA_CONFIG_STRATEGY: COPY_ALWAYS
       host_prep_tasks:
diff --git a/environments/metrics/ceilometer-write-qdr.yaml b/environments/metrics/ceilometer-write-qdr.yaml
index c8558d5fe5..c695597e3d 100644
--- a/environments/metrics/ceilometer-write-qdr.yaml
+++ b/environments/metrics/ceilometer-write-qdr.yaml
@@ -8,4 +8,5 @@ resource_registry:
   OS::TripleO::Services::ComputeCeilometerAgent: ../../deployment/ceilometer/ceilometer-agent-compute-container-puppet.yaml
 
 parameter_defaults:
+  CeilometerEnablePanko: false
   CeilometerQdrPublish: true