From 69b03c45dae8e0b63a2e6c641ba7cd6b6c7e2669 Mon Sep 17 00:00:00 2001
From: Emilien Macchi <emilien@redhat.com>
Date: Tue, 2 May 2017 12:15:08 -0400
Subject: [PATCH] snmp: add SnmpdBindHost parameter

SnmpdBindHost will be useful for users who want to change the binding
options for SNMP daemon.
It has to be an array, and by the default the value is
['udp:161','udp6:[::1]:161'] like it was in puppet-tripleo profile.

Change-Id: Iccf0a8d35cc05d34272c078c97a5dddfb8e7d614
Closes-Bug: #1687628
(cherry picked from commit 6ec49bdddab58463d8f99ea4316857f41d4278e5)
---
 puppet/services/snmp.yaml                            | 5 +++++
 releasenotes/notes/snmp_listen-2364188f73d43b14.yaml | 7 +++++++
 2 files changed, 12 insertions(+)
 create mode 100644 releasenotes/notes/snmp_listen-2364188f73d43b14.yaml

diff --git a/puppet/services/snmp.yaml b/puppet/services/snmp.yaml
index 80c29f957c..072ccc1a17 100644
--- a/puppet/services/snmp.yaml
+++ b/puppet/services/snmp.yaml
@@ -28,6 +28,10 @@ parameters:
     description: The user password for SNMPd with readonly rights running on all Overcloud nodes
     type: string
     hidden: true
+  SnmpdBindHost:
+    description: An array of bind host addresses on which SNMP daemon will listen.
+    type: comma_delimited_list
+    default: ['udp:161','udp6:[::1]:161']
 
 outputs:
   role_data:
@@ -37,6 +41,7 @@ outputs:
       config_settings:
         tripleo::profile::base::snmp::snmpd_user: {get_param: SnmpdReadonlyUserName}
         tripleo::profile::base::snmp::snmpd_password: {get_param: SnmpdReadonlyUserPassword}
+        snmp::agentaddress: {get_param: SnmpdBindHost}
         tripleo.snmp.firewall_rules:
           '127 snmp':
             dport: 161
diff --git a/releasenotes/notes/snmp_listen-2364188f73d43b14.yaml b/releasenotes/notes/snmp_listen-2364188f73d43b14.yaml
new file mode 100644
index 0000000000..7cff9eec8e
--- /dev/null
+++ b/releasenotes/notes/snmp_listen-2364188f73d43b14.yaml
@@ -0,0 +1,7 @@
+---
+features:
+  - |
+    Adding a new parameter to SNMP profile, SnmpdBindHost
+    so users can change the binding addresses on SNMP daemon.
+    The parameter is an array and takes the default value that
+    were previously hardcoded in puppet-tripleo.