Fix Ansible Using tests as filters is deprecated

Avoids deprecation warnings like below by adopting recommended syntax.

[DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of
using `result|failed` instead use `result is failed`. This feature will
be removed in version 2.9. Deprecation warnings can be disabled by
setting deprecation_warnings=False in ansible.cfg.

Change-Id: Ie0e0fbc61090e2b89971252ee60700158acf5fd4
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>

roles/build-test-packages/tasks/dlrn-build.yml

@@ -62,7 +62,7 @@
         dest: '{{ build_repo_dir }}/DLRN/data/{{ project_name_mapped.stdout }}'
         refspec: '{{ artg_change.refspec }}'
         version: 'FETCH_HEAD'
-      when: artg_repos_dir is not defined or copy_dir|failed
+      when: artg_repos_dir is not defined or copy_dir is failed
 
     - name: Run DLRN
       shell: >

roles/multinodes/tasks/main.yml

@@ -140,7 +140,7 @@
   command:
     ssh -o BatchMode=yes -o "StrictHostKeyChecking=no" centos@{{ hostvars[item].ansible_host }} -i "{{ private_key_location }}"
   register: result
-  until: result|success
+  until: result is success
   retries: 100
   delay: 5
   with_items:

roles/ovb-manage-stack/tasks/ovb-create-stack.yml

@@ -138,7 +138,7 @@
   command:
       ssh -o BatchMode=yes -o "StrictHostKeyChecking=no" root@{{ undercloud_ip }} -i "{{ undercloud_key }}"
   register: result
-  until: result|success
+  until: result is success
   retries: 300
   delay: 5
 

roles/overcloud-prep-config/tasks/main.yml

@@ -57,11 +57,10 @@
   when: baremetal_nic_configs is defined
 
 - name: Prepare custom t-h-t for overcloud deployment
-  include: custom_tht.yml
+  import_tasks: custom_tht.yml
   when:
      - overcloud_templates_refspec is defined or overcloud_templates_branch is defined
      - overcloud_templates_repo is defined
-  static: no
 
 - name: Copy extra THT config files on the undercloud
   copy: