diff --git a/roles/collect-logs/templates/get_host_info.sh.j2 b/roles/collect-logs/templates/get_host_info.sh.j2 index 5fc9dfed1..2d1c80822 100644 --- a/roles/collect-logs/templates/get_host_info.sh.j2 +++ b/roles/collect-logs/templates/get_host_info.sh.j2 @@ -53,5 +53,7 @@ EOC # NOTE(bnemec): openstack stack failures list only exists in Newton and above. # On older releases we still need to manually query the deployments. openstack stack failures list --long overcloud || for failed_deployment in \$(heat resource-list --nested-depth 5 overcloud | grep FAILED | grep 'StructuredDeployment ' | cut -d '|' -f3); do heat deployment-show \$failed_deployment; done; + # NOTE(emilien) "openstack overcloud failures" was introduced in Rocky + openstack overcloud failures || true EOF fi diff --git a/roles/multinodes/tasks/delete_stack.yml b/roles/multinodes/tasks/delete_stack.yml index 471382a28..e8f74f950 100644 --- a/roles/multinodes/tasks/delete_stack.yml +++ b/roles/multinodes/tasks/delete_stack.yml @@ -10,6 +10,8 @@ echo "Failed deleting OVB stack" | tee -a {{ stack_log }}; openstack stack show {{ stack_name }} &>> {{ stack_log }}; openstack stack failures list --long {{ stack_name }} &>> {{ stack_log }} || echo 'Failed to list stack failures' >> {{ stack_log }}; + # NOTE(emilien) "openstack overcloud failures" was introduced in Rocky + openstack overcloud failures &>> {{ stack_log }} || echo 'Failed to list deployment failures' >> {{ stack_log }}; exit 0; fi; COUNTER=$((COUNTER+1)); diff --git a/roles/overcloud-deploy/templates/overcloud-deploy.sh.j2 b/roles/overcloud-deploy/templates/overcloud-deploy.sh.j2 index 72817807f..9f016d70d 100644 --- a/roles/overcloud-deploy/templates/overcloud-deploy.sh.j2 +++ b/roles/overcloud-deploy/templates/overcloud-deploy.sh.j2 @@ -82,6 +82,8 @@ elif ! openstack stack list | grep -Eq '(CREATE|UPDATE)_COMPLETE'; then {%if release not in ['mitaka', 'liberty'] %} # get the failures list openstack stack failures list overcloud --long > {{ failed_deployment_list }} || true + # NOTE(emilien) "openstack overcloud failures" was introduced in Rocky + openstack overcloud failures >> {{ failed_deployment_list }} || true {% endif %} # get any puppet related errors diff --git a/roles/overcloud-upgrade/templates/major-upgrade-overcloud-containers.sh.j2 b/roles/overcloud-upgrade/templates/major-upgrade-overcloud-containers.sh.j2 index 9f597a1ac..84d9ed483 100644 --- a/roles/overcloud-upgrade/templates/major-upgrade-overcloud-containers.sh.j2 +++ b/roles/overcloud-upgrade/templates/major-upgrade-overcloud-containers.sh.j2 @@ -6,6 +6,8 @@ onerror(){ # get the failures list openstack stack resource list overcloud >> failed_upgrade_list.log || true openstack stack failures list --long overcloud >> failed_upgrade.log + # NOTE(emilien) "openstack overcloud failures" was introduced in Rocky + openstack overcloud failures >> failed_upgrade.log || true exit 1 } trap onerror ERR