openstack
/
tripleo-quickstart
Code Issues Proposed changes

Fix default value of tempestconf overrides 

The current default value is literraly 'omit' which is incorrect.
If a users doesn't have any intention to override any tempestconf
values, the overrides should be an empty dict or not set at all [1].

The review sets the default value of tempestconf overrides to
an empty dict as shown in the doc [1].

[1] https://docs.openstack.org/python-tempestconf/latest/user/profile.html

Change-Id: Ifd791bae7982154fd097774a3992530675278345
This commit is contained in:
Martin Kopec 2020-03-30 18:58:39 +00:00
parent 7953f5e87b
commit 4d7021d93f
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/general_config/featureset001.yml
View File

@ -185,7 +185,7 @@ tempest_tempestconf_profile:
os-cloud: "{{ tempest_cloud_name }}"
out: "{{ tempest_workspace }}/etc/tempest.conf"
network-id: "{{ tempest_neutron_public_network_id }}"
overrides: "{{ tempest_tempest_conf_overrides | default('omit') }}"
overrides: "{{ tempest_tempest_conf_overrides | default({}) }}"
tempest_tempest_conf_overrides:
auth.use_dynamic_credentials: 'True'

2
config/general_config/featureset020.yml
View File

@ -205,7 +205,7 @@ tempest_tempestconf_profile:
os-cloud: "{{ tempest_cloud_name }}"
out: "{{ tempest_workspace }}/etc/tempest.conf"
network-id: "{{ tempest_neutron_public_network_id }}"
overrides: "{{ tempest_tempest_conf_overrides | default('omit') }}"
overrides: "{{ tempest_tempest_conf_overrides | default({}) }}"
check_test_whitelist:
- 'tempest.scenario'

2
config/general_config/featureset021.yml
View File

@ -226,7 +226,7 @@ tempest_tempestconf_profile:
os-cloud: "{{ tempest_cloud_name }}"
out: "{{ tempest_workspace }}/etc/tempest.conf"
network-id: "{{ tempest_neutron_public_network_id }}"
overrides: "{{ tempest_tempest_conf_overrides | default('omit') }}"
overrides: "{{ tempest_tempest_conf_overrides | default({}) }}"
# Run skiplist as whitelist
tempest_test_whitelist: "{{ tempest_whitelist }}"

2
config/general_config/featureset030.yml
View File

@ -142,6 +142,6 @@ tempest_tempestconf_profile:
os-cloud: "{{ tempest_cloud_name }}"
out: "{{ tempest_workspace }}/etc/tempest.conf"
network-id: "{{ tempest_neutron_public_network_id }}"
overrides: "{{ tempest_tempest_conf_overrides | default('omit') }}"
overrides: "{{ tempest_tempest_conf_overrides | default({}) }}"
tempest_test_whitelist: "{{ tempest_whitelist }}"

2
config/general_config/featureset035.yml
View File

@ -190,7 +190,7 @@ tempest_tempestconf_profile:
os-cloud: "{{ tempest_cloud_name }}"
out: "{{ tempest_workspace }}/etc/tempest.conf"
network-id: "{{ tempest_neutron_public_network_id }}"
overrides: "{{ tempest_tempest_conf_overrides | default('omit') }}"
overrides: "{{ tempest_tempest_conf_overrides | default({}) }}"
tempest_tempest_conf_overrides:
auth.use_dynamic_credentials: 'True'