openstack
/
tripleo-validations
Code Issues Proposed changes

Triggering overcloud container CLI discovery task on allovercloud group 

The overcloud container CLI was previously only discovered if overcloud group
was present in the inventory. As one of the validations targets,
the 'allovercloud' group over took much of the previous 'overcloud' group responsibilities.

This could lead to an edge case when no overcloud container CLI was discovered on overcloud nodes,
and the undercloud cli was never sought. The relevant variable remained
unfilled and caused eventual syntax error during evaluation of a conditional
in the following task.

Resolves: rhbz#2127928

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
Change-Id: I84a7c20a41698d57a379720ef0424f5220bb9edd
(cherry picked from commit 29ad8ab342)
This commit is contained in:
Jiri Podivin 2022-09-20 16:02:58 +02:00
parent 6be51cd366
commit 57d7b26bb5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/container_status/tasks/main.yaml
View File

@ -3,7 +3,7 @@
set_fact:
oc_container_cli: "{{ hostvars[inventory_hostname].container_cli | default('podman', true) }}"
when:
- "'overcloud' in group_names"
- "'overcloud' in group_names or 'allovercloud' in group_names"
- oc_container_cli is not defined
- when: "'Undercloud' in group_names"