Merge "Add validation for checking baremetal boot images" into stable/queens

validations/deployment-images.yaml

@@ -5,18 +5,29 @@
       name: Verify existence of deployment images
       description: >
         This validation checks that images bm-deploy-kernel and
-        bm-deploy-ramdisk exist before deploying the overcloud.
+        bm-deploy-ramdisk exist before deploying the overcloud,
+        and that only one exists by that name.
       groups:
       - pre-deployment
+      - pre-upgrade
+    deploy_kernel_name: "bm-deploy-kernel"
+    deploy_ramdisk_name: "bm-deploy-ramdisk"
   tasks:
-  - name: Fetch available images
-    command: openstack image list --format value --column Name
-    register: shell_result
-    changed_when: False
-
-  - name: Check for required images
-    fail: msg="The image {{ item }} is missing."
-    when: "item not in shell_result.stdout"
+  - name: Fetch deploy kernel by name
+    set_fact:
+      deploy_kernel_id: "{{ lookup('glance_images', 'name', ['{{ deploy_kernel_name }}'], wantlist=True) | map(attribute='id') | list }}"
+  - name: Fetch deploy ramdisk by name
+    set_fact:
+      deploy_ramdisk_id: "{{ lookup('glance_images', 'name', ['{{ deploy_ramdisk_name }}'], wantlist=True) | map(attribute='id') | list }}"
+  - name: Fail if image is not found
+    fail: msg="No image with the name '{{ item.name }}' found - make sure you have uploaded boot images."
+    failed_when: item.id | length < 1
     with_items:
-    - bm-deploy-kernel
-    - bm-deploy-ramdisk
+      - { name: '{{deploy_kernel_name}}', id: '{{deploy_kernel_id}}' }
+      - { name: '{{deploy_ramdisk_name}}', id: '{{deploy_ramdisk_id}}' }
+  - name: Fail if there is more than one image
+    fail: msg="Please make sure there is only one image named '{{ item.name }}' in glance."
+    failed_when: item.id | length > 1
+    with_items:
+      - { name: '{{deploy_kernel_name}}', id: '{{deploy_kernel_id}}' }
+      - { name: '{{deploy_ramdisk_name}}', id: '{{deploy_ramdisk_id}}' }

validations/lookup_plugins/glance_images.py

@@ -0,0 +1,84 @@
+#!/usr/bin/env python
+
+# Copyright 2018 Red Hat, Inc.
+# All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+from ansible.plugins.lookup import LookupBase
+from glanceclient import client as glance_client
+from glanceclient.exc import HTTPNotFound
+
+from tripleo_validations.utils import get_auth_session
+
+
+DOCUMENTATION = """
+    lookup: glance_images
+    description: Retrieve image information from Glance
+    long_description:
+      - Load image information using the Glance API and search by attribute.
+    options:
+      _terms:
+        description: Optional filter attribute and filter value
+    author: Brad P. Crochet <brad@redhat.com>
+"""
+
+EXAMPLES = """
+    - name: Get all image ids from glance
+      debug:
+        msg: |
+             {{ lookup('glance_images', wantlist=True) |
+             map(attribute='id') | join(', ') }}
+
+    - name: Get image with name 'overcloud-full'
+      debug:
+        msg: |
+             {{ lookup('glance_images', 'name', ['overcloud-full'],
+             wantlist=True) | map(attribute='name') }}"
+"""
+
+RETURN = """
+_raw:
+    description: A Python list with results from the API call.
+"""
+
+
+class LookupModule(LookupBase):
+
+    def run(self, terms, variables=None, **kwargs):
+        """Returns server information from nova."""
+        auth_url = variables.get('auth_url')
+        username = variables.get('username')
+        project_name = variables.get('project_name')
+        token = variables.get('os_auth_token')
+        session = get_auth_session(auth_url, username, project_name,
+                                   auth_token=token)
+        glance = glance_client.Client(2, session=session)
+
+        images = []
+        if len(terms) > 0:
+            # Look up images by name
+            if terms[0] == 'name':
+                for value in terms[1]:
+                    try:
+                        search_data = {terms[0]: value}
+                        images.extend(
+                            [image for image in
+                             glance.images.list(filters=search_data)]
+                        )
+                    except HTTPNotFound:
+                        pass
+        else:
+            images = [image for image in glance.images.list()]
+
+        return images