tripleo-validations/roles/neutron_sanity_check
Bernard Cafarelli 7c01af7988 Fix neutron_sanity_check for ML2/OVS overcloud
Previously validator failed running on neutron_api as the
neutron-sanity-check binary requires additional capabilities, causing it
to alway fail [0]. In addition, in some cases a race condition in
oslo_privsep can cause the validator to hang indefinitely [1].

This fixes it if the overcloud uses ML2/OVS, using the neutron_ovs_agent
container as we already did on the undercloud, and skipping the check if
it cannot be found (ML2/OVN deployments typically).

Additional fixes to the validator:
* skip gather_facts step
* fix output parsing
* call neutron-sanity-check only once, with all configuration files
  passed to it
* drop redundant default values in playbook itself

[0] https://bugzilla.redhat.com/show_bug.cgi?id=1783195
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1862364

Change-Id: Ifacbbd6a493019e606105f45f0302bf1a88bed62
Co-Authored-By: Cédric Jeanneret <cjeanner@redhat.com>
(cherry picked from commit 3561628f2a)
2020-08-05 08:43:34 +00:00
..
defaults Fix neutron_sanity_check for ML2/OVS overcloud 2020-08-05 08:43:34 +00:00
molecule/default Convert all of the fedora28 container usage to CentOS8 2020-03-30 06:54:09 +02:00
tasks Fix neutron_sanity_check for ML2/OVS overcloud 2020-08-05 08:43:34 +00:00