From f6659e8045cd4471d64c9ad5b1ab6a69fb541279 Mon Sep 17 00:00:00 2001 From: jiansong Date: Mon, 12 Jun 2017 23:53:26 -0700 Subject: [PATCH] Redis 'repl-backlog-size' conf parameter using wrong MIN value Redis configuration validation for the 'repl-backlog-size' parameter uses a wrong MIN value of '0'.When set to less than 16384 value, I can see that the value in redis.conf[1], but through the 'config get *' see are 16384[2]. Because the minimum default value in redis is 16384[3]. So I want to modify Min value to 16384. [1]: repl-backlog-size 0 [2]: 59) "repl-backlog-size" 60) "16384" [3]:https://github.com/antirez/redis/blob/58f79e2ff48bb20e48d5eb60ff6a87c9afae5fe9/src/server.h#L110 Closes-Bug: #1697596 Change-Id: I81cb1c02943edf0af3d7bf67ff2f083a4c07d518 --- .../notes/fix-redis-configuration-f0543ede84f8aac3.yaml | 6 ++++++ trove/templates/redis/validation-rules.json | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/fix-redis-configuration-f0543ede84f8aac3.yaml diff --git a/releasenotes/notes/fix-redis-configuration-f0543ede84f8aac3.yaml b/releasenotes/notes/fix-redis-configuration-f0543ede84f8aac3.yaml new file mode 100644 index 0000000000..bceea56b8c --- /dev/null +++ b/releasenotes/notes/fix-redis-configuration-f0543ede84f8aac3.yaml @@ -0,0 +1,6 @@ +--- +fixes: + - Fixes an issue with redis configuration,it use a wrong min value + for repl-backlog-size in validation rules. + Bug 1697596 + diff --git a/trove/templates/redis/validation-rules.json b/trove/templates/redis/validation-rules.json index 8d6973b464..ea5625877d 100644 --- a/trove/templates/redis/validation-rules.json +++ b/trove/templates/redis/validation-rules.json @@ -90,7 +90,7 @@ { "name": "repl-backlog-size", "restart_required": false, - "min": 0, + "min": 16384, "type": "integer" }, {