From 51f27383c8f63190658d758319ba5d7a7de203fe Mon Sep 17 00:00:00 2001 From: "Gael Chamoulaud (Strider)" Date: Tue, 20 Oct 2020 14:56:29 +0200 Subject: [PATCH] Exclude non failing gathering facts action in simplified result The warnings key while gathering facts is set to an empty list if this action pass successfully. This patch excludes successful gathering facts action and grab action logs when some real warnings are present. Change-Id: I23a81c57774bb6259d071b0c3da3a309fc33986c Signed-off-by: Gael Chamoulaud (Strider) --- validations_common/callback_plugins/validation_json.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/validations_common/callback_plugins/validation_json.py b/validations_common/callback_plugins/validation_json.py index f189836..88f1cef 100644 --- a/validations_common/callback_plugins/validation_json.py +++ b/validations_common/callback_plugins/validation_json.py @@ -171,7 +171,7 @@ class CallbackModule(CallbackBase): self.simple_results.append(self._val_task(task.name)) self.simple_results[-1]['task']['status'] = "FAILED" self.simple_results[-1]['task']['hosts'][host.name] = task_result - if 'warnings' in task_result.keys(): + if 'warnings' in task_result.keys() and task_result.get('warnings'): self.simple_results.append(self._val_task(task.name)) self.simple_results[-1]['task']['status'] = "WARNING" self.simple_results[-1]['task']['hosts'][host.name] = task_result