From 5d70c207cddbaedceba6e1e6e9ae89bbd851aacc Mon Sep 17 00:00:00 2001 From: Alfredo Moralejo Date: Thu, 15 Sep 2022 16:51:54 +0200 Subject: [PATCH] Fix compatibility with oslo.db 12.1.0 oslo.db 12.1.0 has changed the default value for the 'autocommit' parameter of 'LegacyEngineFacade' from 'True' to 'False'. This is a necessary step to ensure compatibility with SQLAlchemy 2.0. However, we are currently relying on the autocommit behavior and need changes to explicitly manage sessions. Until that happens, we need to override the default. Co-Authored-By: Stephen Finucane Change-Id: I7db39d958d087322bfa0aad70dfbd04de9228dd7 --- watcher/db/sqlalchemy/api.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/watcher/db/sqlalchemy/api.py b/watcher/db/sqlalchemy/api.py index ab1fc84fb..a13cc566c 100644 --- a/watcher/db/sqlalchemy/api.py +++ b/watcher/db/sqlalchemy/api.py @@ -44,7 +44,11 @@ _FACADE = None def _create_facade_lazily(): global _FACADE if _FACADE is None: - _FACADE = db_session.EngineFacade.from_config(CONF) + # FIXME(amoralej): Remove autocommit=True (and ideally use of + # LegacyEngineFacade) asap since it's not compatible with SQLAlchemy + # 2.0. + _FACADE = db_session.EngineFacade.from_config(CONF, + autocommit=True) return _FACADE