openstack
/
watcher
Code Issues Proposed changes

Fix version header in the response 

This patch updates response header
from OpenStack-API-Version: [VERSION_STRING]
to OpenStack-API-Version: [SERVICE_TYPE] [VERSION_STRING]

Change-Id: I10577ff1123ef781bd4aa0b26577574a3f7e9c39
This commit is contained in:
licanwei 2018-11-09 10:44:35 +08:00 committed by Hidekazu Nakamura
parent 59cae3268e
commit 9f09abd6ec
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
watcher/api/controllers/v1/__init__.py
View File

@ -250,7 +250,8 @@ class Controller(rest.RestController):
# assert that requested version is supported
self._check_version(v, pecan.response.headers)
pecan.response.headers[base.Version.string] = str(v)
pecan.response.headers[base.Version.string] = (
' '.join([versions.service_type_string(), str(v)]))
pecan.request.version = v
return super(Controller, self)._route(args, request)

12
watcher/tests/api/v1/test_microversions.py
View File

@ -52,7 +52,8 @@ class TestMicroversions(api_base.FunctionalTest):
return_json=False)
self.assertEqual(response.headers[H_MIN_VER], MIN_VER)
self.assertEqual(response.headers[H_MAX_VER], MAX_VER)
self.assertEqual(response.headers[H_RESP_VER], MIN_VER)
self.assertEqual(response.headers[H_RESP_VER],
' '.join([SERVICE_TYPE, MIN_VER]))
self.assertTrue(all(x in response.json.keys() for x in
self.controller_list_response))
@ -60,7 +61,8 @@ class TestMicroversions(api_base.FunctionalTest):
response = self.get_json('/', return_json=False)
self.assertEqual(response.headers[H_MIN_VER], MIN_VER)
self.assertEqual(response.headers[H_MAX_VER], MAX_VER)
self.assertEqual(response.headers[H_RESP_VER], MIN_VER)
self.assertEqual(response.headers[H_RESP_VER],
' '.join([SERVICE_TYPE, MIN_VER]))
self.assertTrue(all(x in response.json.keys() for x in
self.controller_list_response))
@ -72,7 +74,8 @@ class TestMicroversions(api_base.FunctionalTest):
return_json=False)
self.assertEqual(response.headers[H_MIN_VER], MIN_VER)
self.assertEqual(response.headers[H_MAX_VER], MAX_VER)
self.assertEqual(response.headers[H_RESP_VER], '1.1')
self.assertEqual(response.headers[H_RESP_VER],
' '.join([SERVICE_TYPE, '1.1']))
self.assertTrue(all(x in response.json.keys() for x in
self.controller_list_response))
@ -84,7 +87,8 @@ class TestMicroversions(api_base.FunctionalTest):
return_json=False)
self.assertEqual(response.headers[H_MIN_VER], MIN_VER)
self.assertEqual(response.headers[H_MAX_VER], MAX_VER)
self.assertEqual(response.headers[H_RESP_VER], MAX_VER)
self.assertEqual(response.headers[H_RESP_VER],
' '.join([SERVICE_TYPE, MAX_VER]))
self.assertTrue(all(x in response.json.keys() for x in
self.controller_list_response))