openstack
/
watcher
Code Issues Proposed changes

Merge "optimize update_audit_state"

This commit is contained in:
Zuul 2017-10-17 01:19:31 +00:00 committed by Gerrit Code Review
parent 8343f4bf46 7f9b562bbd
commit b35feb5432
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
watcher/decision_engine/audit/base.py
View File

@ -96,9 +96,10 @@ class AuditHandler(BaseAuditHandler):
raise
def update_audit_state(self, audit, state):
LOG.debug("Update audit state: %s", state)
audit.state = state
audit.save()
if audit.state != state:
LOG.debug("Update audit state: %s", state)
audit.state = state
audit.save()
def check_ongoing_action_plans(self, request_context):
a_plan_filters = {'state': objects.action_plan.State.ONGOING}

2
watcher/tests/decision_engine/audit/test_audit_handlers.py
View File

@ -338,8 +338,6 @@ class TestContinuousAuditHandler(base.DbTestCase):
mock_jobs.return_value = mock.MagicMock()
m_service.return_value = mock.MagicMock()
m_engine.return_value = mock.MagicMock()
self.audits[1].state = objects.audit.State.CANCELLED
self.audits[0].state = objects.audit.State.SUSPENDED
ap_jobs = [job.Job(mock.MagicMock(), name='execute_audit',
func=audit_handler.execute_audit,