From bf040c1abb65b9d2f2949739fde9a537cce2e40e Mon Sep 17 00:00:00 2001 From: Feng Shengqin Date: Fri, 4 Jan 2019 16:39:30 +0800 Subject: [PATCH] Reduce the number of calling container.save Change-Id: I8c8cb89eec6f7038a7b032cccc0181d08d8bfe57 --- zun/compute/manager.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/zun/compute/manager.py b/zun/compute/manager.py index 3abc9d81c..225e490b7 100644 --- a/zun/compute/manager.py +++ b/zun/compute/manager.py @@ -482,7 +482,7 @@ class Manager(periodic_task.PeriodicTasks): self._update_task_state(context, container, consts.CONTAINER_STARTING) try: container = self.driver.start(context, container) - self._update_task_state(context, container, None) + container.task_state = None container.started_at = timeutils.utcnow() container.save(context) return container @@ -576,10 +576,9 @@ class Manager(periodic_task.PeriodicTasks): self._update_task_state(context, container, consts.SG_REMOVING) self.driver.remove_security_group(context, container, security_group) - self._update_task_state(context, container, None) - security_groups = (set(container.security_groups) - - set([security_group])) - container.security_groups = list(security_groups) + container.task_state = None + container.security_groups = list(set(container.security_groups) + - set([security_group])) container.save(context) @translate_exception