From 8f4e1ac20de41b3c8d0fc2474ab4974afe4d350b Mon Sep 17 00:00:00 2001 From: Florian Apolloner Date: Mon, 5 Nov 2018 20:33:38 +0100 Subject: [PATCH] Set exit code to 1 if at least one linter fails. Change-Id: I802a7e4221d35c5a0c5f7a1320ea267b1e59d1fc --- tests/linters.sh | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/linters.sh b/tests/linters.sh index 9385bd9..f345cc5 100755 --- a/tests/linters.sh +++ b/tests/linters.sh @@ -20,6 +20,7 @@ tests=$(dirname $0) export PROJECT_ROOT=$(cd `dirname $tests` && pwd -P) export PROJECT_LIB="${PROJECT_ROOT}/ara" +ret=0 function banner() { echo @@ -40,14 +41,25 @@ fi banner black time black --diff --check "${PROJECT_LIB}" +ret+=$? banner isort time isort --recursive --check-only --diff "${PROJECT_LIB}" +ret+=$? banner flake8 time flake8 "${PROJECT_LIB}" +ret+=$? # B303 - Use of insecure MD2, MD4, or MD5 hash function. # We're using sha1 to generate a hash of file contents. banner bandit time bandit -r "${PROJECT_LIB}" --skip B303 +ret+=$? + +if [ $ret -gt 0 ] +then + echo + echo "At least one linter detected errors!" + exit 1 +fi