From b80b29da0585c8161bbcc98bd8c21961365fd7a5 Mon Sep 17 00:00:00 2001 From: Gerrit User 35748 <35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 10 Apr 2024 17:26:20 +0000 Subject: [PATCH] Update patch set 15 Patch Set 15: (8 comments) Patch-set: 15 Attention: {"person_ident":"Gerrit User 35748 \u003c35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"} --- 12fb7d2f6ccda8239e6434d63e5d0e19025be24b | 144 +++++++++++++++++++++++ 98519be2617b3046df4b4bf1fdd2c5a7baa90c5c | 24 ++++ 2 files changed, 168 insertions(+) diff --git a/12fb7d2f6ccda8239e6434d63e5d0e19025be24b b/12fb7d2f6ccda8239e6434d63e5d0e19025be24b index 994cc2c8..53e93ff6 100644 --- a/12fb7d2f6ccda8239e6434d63e5d0e19025be24b +++ b/12fb7d2f6ccda8239e6434d63e5d0e19025be24b @@ -23,6 +23,30 @@ "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "bd5a80b4_90dca3a5", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py", + "patchSetId": 14 + }, + "lineNbr": 996, + "author": { + "id": 35748 + }, + "writtenOn": "2024-04-10T17:26:20Z", + "side": 1, + "message": "Done", + "parentUuid": "e27b8431_aa417bf7", + "range": { + "startLine": 996, + "startChar": 59, + "endLine": 996, + "endChar": 66 + }, + "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -46,6 +70,30 @@ "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "08f6e941_e0122390", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py", + "patchSetId": 14 + }, + "lineNbr": 1407, + "author": { + "id": 35748 + }, + "writtenOn": "2024-04-10T17:26:20Z", + "side": 1, + "message": "Done", + "parentUuid": "d4040f29_be4827ec", + "range": { + "startLine": 1407, + "startChar": 18, + "endLine": 1407, + "endChar": 23 + }, + "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -63,6 +111,24 @@ "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "ec5692b7_b7a0a426", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py", + "patchSetId": 14 + }, + "lineNbr": 1922, + "author": { + "id": 35748 + }, + "writtenOn": "2024-04-10T17:26:20Z", + "side": 1, + "message": "Done", + "parentUuid": "f0f610a3_5203af71", + "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -80,6 +146,24 @@ "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "8c4da980_52e546c8", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py", + "patchSetId": 14 + }, + "lineNbr": 2154, + "author": { + "id": 35748 + }, + "writtenOn": "2024-04-10T17:26:20Z", + "side": 1, + "message": "Done", + "parentUuid": "e5b29c3d_bd901640", + "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -97,6 +181,24 @@ "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "f8c05737_1cb5194d", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py", + "patchSetId": 14 + }, + "lineNbr": 2163, + "author": { + "id": 35748 + }, + "writtenOn": "2024-04-10T17:26:20Z", + "side": 1, + "message": "Done", + "parentUuid": "c41343c5_fbb8d23b", + "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -120,6 +222,30 @@ "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "490757dc_62244794", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py", + "patchSetId": 14 + }, + "lineNbr": 2165, + "author": { + "id": 35748 + }, + "writtenOn": "2024-04-10T17:26:20Z", + "side": 1, + "message": "Done", + "parentUuid": "8eeda8bd_fb7af7ea", + "range": { + "startLine": 2165, + "startChar": 52, + "endLine": 2165, + "endChar": 96 + }, + "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -136,6 +262,24 @@ "message": "comment on the purpose of this code block. It appears to be unconditionally removing all _ignore_alarms_condition which doesnt appear correct", "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "54a00482_94d0d651", + "filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py", + "patchSetId": 14 + }, + "lineNbr": 2181, + "author": { + "id": 35748 + }, + "writtenOn": "2024-04-10T17:26:20Z", + "side": 1, + "message": "This block of code, will remove only the alarm which is part of nfvi_alarm list\nand which has not yet exceeded the specified timeout.", + "parentUuid": "4b125f82_7289c3fe", + "revId": "12fb7d2f6ccda8239e6434d63e5d0e19025be24b", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file diff --git a/98519be2617b3046df4b4bf1fdd2c5a7baa90c5c b/98519be2617b3046df4b4bf1fdd2c5a7baa90c5c index cc3793df..6fb54516 100644 --- a/98519be2617b3046df4b4bf1fdd2c5a7baa90c5c +++ b/98519be2617b3046df4b4bf1fdd2c5a7baa90c5c @@ -22,6 +22,30 @@ }, "revId": "98519be2617b3046df4b4bf1fdd2c5a7baa90c5c", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "55b0d726_7cb1d0e1", + "filename": "/COMMIT_MSG", + "patchSetId": 12 + }, + "lineNbr": 11, + "author": { + "id": 35748 + }, + "writtenOn": "2024-04-10T17:26:20Z", + "side": 1, + "message": "Done", + "parentUuid": "405975d0_c048f82f", + "range": { + "startLine": 11, + "startChar": 14, + "endLine": 11, + "endChar": 20 + }, + "revId": "98519be2617b3046df4b4bf1fdd2c5a7baa90c5c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file