windmill
/
ansible-role-logrotate
Code Issues Proposed changes

Update patch set 8 

Patch Set 8:

(4 comments)

Patch-set: 8
Label: Verified=0
This commit is contained in:
Gerrit User 4162 2017-05-30 17:07:57 +00:00 committed by Gerrit Code Review
parent 9ceff74ccc
commit b40f15cc87
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
3ed550be2b161e4aaad7569cf46ee13b57ac0b0a
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df140735_788e2b79",
"filename": "tests/test.yaml",
"patchSetId": 8
},
"lineNbr": 25,
"author": {
"id": 4162
},
"writtenOn": "2017-05-30T17:07:57Z",
"side": 1,
"message": "Good idea. I haven\u0027t looked at this logic in a while so this was copy pasta from another role.",
"parentUuid": "df140735_9d59f15b",
"range": {
"startLine": 19,
"startChar": 0,
"endLine": 25,
"endChar": 41
},
"revId": "3ed550be2b161e4aaad7569cf46ee13b57ac0b0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df140735_d8ae57e6",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df140735_5837e7b1",
"filename": "tox.ini",
"patchSetId": 8
},
"lineNbr": 13,
"author": {
"id": 4162
},
"writtenOn": "2017-05-30T17:07:57Z",
"side": 1,
"message": "So, this was to work around some ansible issue a while back. I am not actually sure this is needed any more. Let me confirm.\n\nBut, copypasta from other roles. I\u0027ll be revisiting.",
"parentUuid": "df140735_d8ae57e6",
"range": {
"startLine": 13,
"startChar": 54,
"endLine": 13,
"endChar": 80
},
"revId": "3ed550be2b161e4aaad7569cf46ee13b57ac0b0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df140735_18572f05",
@ -69,6 +117,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df140735_d84ad725",
"filename": "tox.ini",
"patchSetId": 8
},
"lineNbr": 44,
"author": {
"id": 4162
},
"writtenOn": "2017-05-30T17:07:57Z",
"side": 1,
"message": "agree",
"parentUuid": "df140735_18572f05",
"range": {
"startLine": 43,
"startChar": 0,
"endLine": 44,
"endChar": 17
},
"revId": "3ed550be2b161e4aaad7569cf46ee13b57ac0b0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df140735_d83bf7ce",
@ -91,6 +163,30 @@
"revId": "3ed550be2b161e4aaad7569cf46ee13b57ac0b0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "df140735_78518bd8",
"filename": "tox.ini",
"patchSetId": 8
},
"lineNbr": 48,
"author": {
"id": 4162
},
"writtenOn": "2017-05-30T17:07:57Z",
"side": 1,
"message": "++",
"parentUuid": "df140735_d83bf7ce",
"range": {
"startLine": 46,
"startChar": 0,
"endLine": 48,
"endChar": 47
},
"revId": "3ed550be2b161e4aaad7569cf46ee13b57ac0b0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}