x
/
bansho
Code Issues Proposed changes

JSLint: Unused variables raise errors

This commit is contained in:
Frédéric Vachon 2015-02-20 14:38:12 -05:00
parent 9025ba7717
commit 86c9cc76d7
15 changed files with 16 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Gruntfile.js
View File

@ -61,7 +61,6 @@ module.exports = function (grunt) {
],
directives: {
node: true,
unparam: true, // TEMPORARY: Ignore unused params
nomen: true,
predef: [ // Global variables
'document', '$', '$get',

4
app/components/live/get_services.js
View File

@ -13,7 +13,7 @@ angular.module('adagios.live')
})
.factory('getServices', ['$http', 'filterSuffixes',
function ($http, filterSuffixes, columns, filters, apiName) {
function ($http, filterSuffixes) {
return function (columns, filters, apiName) {
var filtersQuery = '';
@ -36,7 +36,7 @@ angular.module('adagios.live')
filtersQuery = createFiltersQuery(filters);
return $http.get('/rest/status/json/' + apiName + '/?fields=' + columns + filtersQuery)
.error(function (data, status, headers, config) {
.error(function () {
throw new Error('getServices : GET Request failed');
});
};

2
app/components/live/notifications.js
View File

@ -2,7 +2,7 @@
angular.module('adagios.live')
.factory('getProblems', ['$http', function ($http) {
.factory('getProblems', [function () {
var problem_number = 44;
return problem_number;

2
app/components/ng-justgage/ng-justgage.js
View File

@ -14,7 +14,7 @@ angular.module("ngJustGage", [])
options: '='
},
template: '<div id="{{id}}-justgage" class="{{class}}"></div>',
link: function (scope, element, attrs) {
link: function (scope) {
$timeout(function () {
var options, key, graph;

2
app/components/sidebar/sidebar.js
View File

@ -2,7 +2,7 @@
angular.module('adagios.sidebar', [])
.controller('SideBarCtrl', ['$scope', '$http', function ($scope, $http) {
.controller('SideBarCtrl', [function () {
angular.noop();
}])

2
app/components/table/cell_duration/cell_duration.js
View File

@ -2,7 +2,7 @@
angular.module('adagios.table.cell_duration', ['adagios.table'])
.controller('CellDurationCtrl', ['$scope', function ($scope) {
.controller('CellDurationCtrl', [function () {
angular.noop();
}])

2
app/components/table/cell_host_address/cell_host_address.js
View File

@ -2,7 +2,7 @@
angular.module('adagios.table.cell_host_address', ['adagios.table'])
.controller('CellHostAddressCtrl', ['$scope', function ($scope) {
.controller('CellHostAddressCtrl', [function () {
angular.noop();
}])

2
app/components/table/cell_hosts_host/cell_hosts_host.js
View File

@ -2,7 +2,7 @@
angular.module('adagios.table.cell_hosts_host', ['adagios.table'])
.controller('CellHostsHostCtrl', ['$scope', function ($scope) {
.controller('CellHostsHostCtrl', [function () {
angular.noop();
}])

2
app/components/table/cell_last_check/cell_last_check.js
View File

@ -2,7 +2,7 @@
angular.module('adagios.table.cell_last_check', ['adagios.table'])
.controller('CellLastCheckCtrl', ['$scope', function ($scope) {
.controller('CellLastCheckCtrl', [function () {
angular.noop();
}])

4
app/components/table/table.js
View File

@ -16,7 +16,7 @@ angular.module('adagios.table', ['adagios.live',
filters: {},
cellToFieldsMap: {} })
.controller('TableCtrl', ['$scope', 'getServices', 'readConfig', 'tableConfig', function ($scope, getServices, readConfig, tableConfig) {
.controller('TableCtrl', ['$scope', 'getServices', 'tableConfig', function ($scope, getServices, tableConfig) {
var requestFields = [],
filters = JSON.parse(tableConfig.filters),
@ -30,7 +30,7 @@ angular.module('adagios.table', ['adagios.live',
$scope.cellIndexes.push(i);
}
angular.forEach($scope.cellsName, function (key, value) {
angular.forEach($scope.cellsName, function (key) {
angular.forEach(tableConfig.cellToFieldsMap[key], function (_value) {
requestFields.push(_value);
});

2
app/components/tactical/current_health/current_health.js
View File

@ -2,7 +2,7 @@
angular.module('adagios.tactical.current_health', ['ngRoute', 'ngJustGage' ])
.controller('TacticalCurrentHealth', ['$scope', '$http', function ($scope, $http) {
.controller('TacticalCurrentHealth', ['$scope', function ($scope) {
$scope.hosts = 75.2;
$scope.services = 94.4;
}])

2
app/components/tactical/status_overview/status_overview.js
View File

@ -2,7 +2,7 @@
angular.module('adagios.tactical.status_overview', ['ngRoute' ])
.controller('TacticalStatusOverViewCtrl', ['$scope', '$http', function ($scope, $http) {
.controller('TacticalStatusOverViewCtrl', ['$scope', function ($scope) {
$scope.hosts = {
"count": 104,
"problems": 14

2
app/components/tactical/tactical.js
View File

@ -5,7 +5,7 @@ angular.module('adagios.tactical', ['adagios.tactical.status_overview',
'adagios.tactical.top_alert_producers'
])
.controller('TacticalCtrl', ['$scope', '$http', function ($scope, $http) {
.controller('TacticalCtrl', [function () {
// Togglable tabs
// Don't follow hyperlinks

2
app/components/tactical/top_alert_producers/top_alert_producers.js
View File

@ -1,7 +1,7 @@
'use strict';
angular.module('adagios.tactical.top_alert_producers', ['ngRoute' ])
.controller('TacticalTopAlertProducers', ['$scope', '$http', function ($scope, $http) {
.controller('TacticalTopAlertProducers', ['$scope', function ($scope) {
$scope.hosts = [
{
"host_name": "server-18",

2
app/components/topbar/topbar.js
View File

@ -2,7 +2,7 @@
angular.module('adagios.topbar', ['adagios.live'])
.controller('TopBarCtrl', ['$scope', '$http', 'getProblems', function ($scope, $http, getProblems) {
.controller('TopBarCtrl', ['$scope', 'getProblems', function ($scope, getProblems) {
$scope.notifications = getProblems;
}])