From 62fb2b10a881ccf52c72e4f867aa7b72dd853eed Mon Sep 17 00:00:00 2001 From: Vu Cong Tuan Date: Tue, 7 Nov 2017 11:16:31 +0700 Subject: [PATCH] =?UTF-8?q?Do=20not=20use=20=E2=80=9C-y=E2=80=9D=20for=20p?= =?UTF-8?q?ackage=20install?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit According to "code conventions" [1], do not use "-y" option. Instead, use apt-get install package, yum install package, or zypper install package. [1] https://docs.openstack.org/doc-contrib-guide/writing-style/ code-conventions.html Change-Id: I19e99efe37ccb15049c920f7e41589c0e22b618a --- doc/source/bareon_on_devstack.rst | 6 +++--- doc/source/contributing.rst | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/source/bareon_on_devstack.rst b/doc/source/bareon_on_devstack.rst index ea1553a..45b4dfe 100644 --- a/doc/source/bareon_on_devstack.rst +++ b/doc/source/bareon_on_devstack.rst @@ -48,8 +48,8 @@ Setup Libvirt .. code-block:: console - yum update -y - yum install -y git + yum update + yum install git reboot @@ -271,7 +271,7 @@ Install Bareon and Build Images .. code-block:: console cd ~/bareon - sudo yum install -y diskimage-builder + sudo yum install diskimage-builder ./bareon/tests_functional/image_build/centos_minimal.sh .. note:: diff --git a/doc/source/contributing.rst b/doc/source/contributing.rst index c8eafb3..926c511 100644 --- a/doc/source/contributing.rst +++ b/doc/source/contributing.rst @@ -56,7 +56,7 @@ Follow the instructions on Running Bareon on Devstack upto and including .. code-block:: console cd ~/bareon - sudo yum install -y ansible + sudo yum install ansible ansible-playbook bareon/tests_functional/ansible/bootstrap_func_tests.yaml sudo NO_DIB=1 tox -e func @@ -76,4 +76,4 @@ environment: .. code-block:: console - $ export BUILD_ENV=/path/to/my_bareon_env.sh \ No newline at end of file + $ export BUILD_ENV=/path/to/my_bareon_env.sh