x
/
browbeat
Code Issues Proposed changes

Update patch set 11 

Patch Set 11:

(3 comments)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 10442 \u003c10442@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10442\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33735 \u003c33735@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_10442\u003e replied on the change"}
This commit is contained in:
Gerrit User 10442 2023-03-16 06:22:35 +00:00 committed by Gerrit Code Review
parent 58a9d67885
commit 41ff1b9d02
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
b78d2e9bb368da087542a29d95472321fcabefa4 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "9804a136_fff36a2b",
"filename": "rally/rally-plugins/nova/nfv_context.py",
"patchSetId": 11
},
"lineNbr": 114,
"author": {
"id": 10442
},
"writtenOn": "2023-03-16T06:22:35Z",
"side": 1,
"message": "instead of using the if-else, check can we use setdefault function to set the key.\nex: self.context[\"nfv_networks\"].setdefault(\"dpdk\", {})",
"revId": "b78d2e9bb368da087542a29d95472321fcabefa4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "58f309f5_715f7c8d",
"filename": "rally/rally-plugins/nova/nfv_context.py",
"patchSetId": 11
},
"lineNbr": 263,
"author": {
"id": 10442
},
"writtenOn": "2023-03-16T06:22:35Z",
"side": 1,
"message": "if the keys are not used below, can we iterate using values() method?",
"revId": "b78d2e9bb368da087542a29d95472321fcabefa4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "65b7a69f_d138a019",
"filename": "rally/rally-plugins/nova/nova.py",
"patchSetId": 11
},
"lineNbr": 98,
"author": {
"id": 10442
},
"writtenOn": "2023-03-16T06:22:35Z",
"side": 1,
"message": "use _ if the range value is not used inside the loop\nex: for _ in range(num):",
"revId": "b78d2e9bb368da087542a29d95472321fcabefa4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}