x
/
browbeat
Code Issues Proposed changes

Update patch set 13 

Patch Set 13:

(2 comments)

Patch-set: 13
Attention: {"person_ident":"Gerrit User 10442 \u003c10442@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10442\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33735 \u003c33735@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_10442\u003e replied on the change"}
This commit is contained in:
Gerrit User 10442 2023-04-14 06:18:11 +00:00 committed by Gerrit Code Review
parent b6065ca80f
commit 590940eca4
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
8e2678dd5ecde1aaa17f34a4db2cad24f21b7320 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "8c8251cc_4da3a613",
"filename": "rally/rally-plugins/nova/nfv_context.py",
"patchSetId": 13
},
"lineNbr": 168,
"author": {
"id": 10442
},
"writtenOn": "2023-04-14T06:18:11Z",
"side": 1,
"message": "Make this false by default, let user enable it from config",
"revId": "8e2678dd5ecde1aaa17f34a4db2cad24f21b7320",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "194fa24c_c6ce8cfa",
"filename": "rally/rally-plugins/nova/nfv_context.py",
"patchSetId": 13
},
"lineNbr": 221,
"author": {
"id": 10442
},
"writtenOn": "2023-04-14T06:18:11Z",
"side": 1,
"message": "use _ if the variable is not used in the below code. here i see the user is not used in side the loop.",
"revId": "8e2678dd5ecde1aaa17f34a4db2cad24f21b7320",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}