From 6fc952452ce59c1fe63a27058ecb938b3edffd44 Mon Sep 17 00:00:00 2001 From: Gerrit User 30421 <30421@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 5 Apr 2024 04:48:59 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (1 comment) Patch-set: 2 Attention: {"person_ident":"Gerrit User 30421 \u003c30421@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_30421\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 34486 \u003c34486@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_30421\u003e replied on the change"} --- d70201a54b80a2647cccbe4a0f8df253b26f67d3 | 27 ++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 d70201a54b80a2647cccbe4a0f8df253b26f67d3 diff --git a/d70201a54b80a2647cccbe4a0f8df253b26f67d3 b/d70201a54b80a2647cccbe4a0f8df253b26f67d3 new file mode 100644 index 000000000..2c0035b77 --- /dev/null +++ b/d70201a54b80a2647cccbe4a0f8df253b26f67d3 @@ -0,0 +1,27 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "fd5e469c_d2fdefc4", + "filename": "ansible/install/roles/collectd/vars/defaults.yml", + "patchSetId": 2 + }, + "lineNbr": 1, + "author": { + "id": 30421 + }, + "writtenOn": "2024-04-05T04:48:59Z", + "side": 1, + "message": "can you move this variable to group_vars/all.yaml as it will be configurable. Also no need of any default. Let the user update it when enabling the sqlalchemy collectd plugin.", + "range": { + "startLine": 1, + "startChar": 0, + "endLine": 1, + "endChar": 12 + }, + "revId": "d70201a54b80a2647cccbe4a0f8df253b26f67d3", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file