Update patch set 2

Patch Set 2:

(9 comments)

Patch-set: 2
CC: Gerrit User 10442 <10442@4a232e18-c5a9-48ee-94c0-e04e7cca6543>

3c86d073d6bb9660d2d177de11fb62749d25201e

@@ -0,0 +1,157 @@
+{
+  "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "d916bb10_5ab6f9c3",
+        "filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 86,
+      "author": {
+        "id": 10442
+      },
+      "writtenOn": "2023-08-24T15:35:11Z",
+      "side": 1,
+      "message": "if the browbeat is installed other than home dir(/home/stack) this will fail",
+      "revId": "3c86d073d6bb9660d2d177de11fb62749d25201e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b3651c60_b55791da",
+        "filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 191,
+      "author": {
+        "id": 10442
+      },
+      "writtenOn": "2023-08-24T15:35:11Z",
+      "side": 1,
+      "message": "unused return values can be replaced with _",
+      "revId": "3c86d073d6bb9660d2d177de11fb62749d25201e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "8576767e_8e160bd0",
+        "filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 228,
+      "author": {
+        "id": 10442
+      },
+      "writtenOn": "2023-08-24T15:35:11Z",
+      "side": 1,
+      "message": "this if block not required just return the exit_code",
+      "revId": "3c86d073d6bb9660d2d177de11fb62749d25201e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b9de0a14_7fda31f2",
+        "filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 250,
+      "author": {
+        "id": 10442
+      },
+      "writtenOn": "2023-08-24T15:35:11Z",
+      "side": 1,
+      "message": "NIT: line #246 and #250 can be bring out of the if block and can be handled with one common if block.",
+      "revId": "3c86d073d6bb9660d2d177de11fb62749d25201e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "25728e54_0a61b6ec",
+        "filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 288,
+      "author": {
+        "id": 10442
+      },
+      "writtenOn": "2023-08-24T15:35:11Z",
+      "side": 1,
+      "message": "check os.chmod method to change the file permission",
+      "revId": "3c86d073d6bb9660d2d177de11fb62749d25201e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "3b700061_a8ef71b6",
+        "filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 310,
+      "author": {
+        "id": 10442
+      },
+      "writtenOn": "2023-08-24T15:35:11Z",
+      "side": 1,
+      "message": "this will delete the values passed as part of arguments, right?",
+      "revId": "3c86d073d6bb9660d2d177de11fb62749d25201e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "a2b5c8ae_3a1e5a97",
+        "filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 316,
+      "author": {
+        "id": 10442
+      },
+      "writtenOn": "2023-08-24T15:35:11Z",
+      "side": 1,
+      "message": "lets use the string formating like other places, f\"nova:{hostname}\"",
+      "revId": "3c86d073d6bb9660d2d177de11fb62749d25201e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "ed175e38_266d9615",
+        "filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 325,
+      "author": {
+        "id": 10442
+      },
+      "writtenOn": "2023-08-24T15:35:11Z",
+      "side": 1,
+      "message": "do we need to pass this empty dict for create volume?",
+      "revId": "3c86d073d6bb9660d2d177de11fb62749d25201e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "49f4bc88_1493449e",
+        "filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 335,
+      "author": {
+        "id": 10442
+      },
+      "writtenOn": "2023-08-24T15:35:11Z",
+      "side": 1,
+      "message": "can you check again this needs to be a assertTrue or assertFalse?",
+      "revId": "3c86d073d6bb9660d2d177de11fb62749d25201e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}