x
/
browbeat
Code Issues Proposed changes

Rename create_clients method for octavia 

With [1] included running octavia scenarios
fails with:-
TypeError: create_clients() takes 6 positional arguments
but 8 were given

This patch renames the octavia specific method to
avoid clases with the inherited method.

[1] https://review.opendev.org/c/x/browbeat/+/860530
Change-Id: If9f763d528308ca83f70fb83b8787935c28b3c07

Change-Id: Ied6df6b0eef2810325a4a6c0a8084bf53b2562de
This commit is contained in:
yatinkarel 2023-09-12 17:50:07 +05:30
parent 8632866417
commit ec32c0cc20
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
rally/rally-plugins/dynamic-workloads/octavia.py
View File

@ -60,8 +60,8 @@ class DynamicOctaviaBase(octavia_utils.OctaviaBase, dynamic_utils.NovaUtils):
jump_ssh.execute("chmod 0600 ~/.ssh/id_rsa")
return jump_ssh, jump_host_ip, jump_host
def create_clients(self, num_clients, user, user_data_file, image,
flavor, subnet, lb_subnet, **kwargs):
def create_clients_lb(self, num_clients, user, user_data_file, image,
flavor, subnet, lb_subnet, **kwargs):
"""Create <num_clients> clients
:param num_clients: int, number of clients to create
@ -286,9 +286,9 @@ class DynamicOctaviaBase(octavia_utils.OctaviaBase, dynamic_utils.NovaUtils):
jump_ssh, jump_host_ip, jump_host = self.build_jump_host(
ext_net_name, octavia_image, octavia_flavor, user, subnets[0]['subnet'], **kwargs)
_clients = self.create_clients(num_clients, user, user_data_file, octavia_image,
octavia_flavor, subnets[1]['subnet'],
subnets[0]['subnet'], **kwargs)
_clients = self.create_clients_lb(num_clients, user, user_data_file, octavia_image,
octavia_flavor, subnets[1]['subnet'],
subnets[0]['subnet'], **kwargs)
protocol_port = 80
# description consists of router id