x
/
browbeat
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(6 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 30421 \u003c30421@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_30421\u003e replied on the change"}
This commit is contained in:
Gerrit User 30421 2023-09-07 07:32:54 +00:00 committed by Gerrit Code Review
parent 3bb8ae616b
commit edc9c50fc0
1 changed files with 102 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

102
ef79b47fd78e7b0cf107c7f90bfb782b8dcbdcbb
View File

@ -1,5 +1,107 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "8a34024d_0ca5384e",
"filename": "browbeat-config.yaml",
"patchSetId": 3
},
"lineNbr": 878,
"author": {
"id": 30421
},
"writtenOn": "2023-09-07T07:32:54Z",
"side": 1,
"message": "add a readme for the usage of the workload",
"revId": "ef79b47fd78e7b0cf107c7f90bfb782b8dcbdcbb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d02575cc_3bc7a182",
"filename": "rally/rally-plugins/pbench-fio/ansible/bootstrap.yaml",
"patchSetId": 3
},
"lineNbr": 18,
"author": {
"id": 30421
},
"writtenOn": "2023-09-07T07:32:54Z",
"side": 1,
"message": "NIT become is set to true on playbook level, can be removed at task level not needed",
"revId": "ef79b47fd78e7b0cf107c7f90bfb782b8dcbdcbb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bc9ee1cb_7d9e3c9b",
"filename": "rally/rally-plugins/pbench-fio/ansible/bootstrap.yaml",
"patchSetId": 3
},
"lineNbr": 69,
"author": {
"id": 30421
},
"writtenOn": "2023-09-07T07:32:54Z",
"side": 1,
"message": "same here",
"revId": "ef79b47fd78e7b0cf107c7f90bfb782b8dcbdcbb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b818a474_77054795",
"filename": "rally/rally-plugins/pbench-fio/ansible/pbench_agent_tool_meister_firewall.yml",
"patchSetId": 3
},
"lineNbr": 17,
"author": {
"id": 30421
},
"writtenOn": "2023-09-07T07:32:54Z",
"side": 1,
"message": "use systemd module",
"revId": "ef79b47fd78e7b0cf107c7f90bfb782b8dcbdcbb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "299cce6b_d3a0d0bd",
"filename": "rally/rally-plugins/pbench-fio/pbench-fio.yml",
"patchSetId": 3
},
"lineNbr": 4,
"author": {
"id": 30421
},
"writtenOn": "2023-09-07T07:32:54Z",
"side": 1,
"message": "can you add some default values if the user has not passed it from browbeat-config.yaml",
"revId": "ef79b47fd78e7b0cf107c7f90bfb782b8dcbdcbb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "81a06d93_5f95f7b5",
"filename": "rally/rally-plugins/pbench-fio/pbench_fio.py",
"patchSetId": 3
},
"lineNbr": 56,
"author": {
"id": 30421
},
"writtenOn": "2023-09-07T07:32:54Z",
"side": 1,
"message": "can we something like rally_result_dir_path + /pbench and then push results and logs under same dir",
"revId": "ef79b47fd78e7b0cf107c7f90bfb782b8dcbdcbb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {