x
/
cloudbase-init
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review+2

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 8543 <8543@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, 92ed1799b2a806347a6b809f7e078a4991f3c76b
This commit is contained in:
Gerrit User 8543 2024-01-09 10:07:05 +00:00 committed by Gerrit Code Review
parent 67245e3191
commit 71a47bdd11
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
49741d9647f9e55fdfe9875141d2b934309e320c Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "34dab5a5_14a99fd4",
"filename": "cloudbaseinit/metadata/services/nocloudservice.py",
"patchSetId": 2
},
"lineNbr": 284,
"author": {
"id": 8543
},
"writtenOn": "2024-01-09T10:07:05Z",
"side": 1,
"message": "I\u0027d say it\u0027s reasonable.\n\nThe alternative would be to do the check ourselves by catching NotExistingMetadataException or adding another method called _has_data, but then we\u0027d also have to update this https://github.com/cloudbase/cloudbase-init/blob/07cae6e8c7785e74622e14114a98b6289465d7ca/cloudbaseinit/metadata/services/osconfigdrive/windows.py#L214.\n\nI guess we can keep it simple and go with the config option.",
"revId": "49741d9647f9e55fdfe9875141d2b934309e320c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}