Update patch set 1
Patch Set 1: (2 comments) A few small comments (simple issues). I would be glad to merge ASAP, once these are addressed. (Sorry, since I am merging them, I also needed to review.) Patch-set: 1 Label: Verified=0
This commit is contained in:
parent
3b02ef82ea
commit
f18c0effd1
|
@ -0,0 +1,38 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ff570b3c_99bf9bfa",
|
||||
"filename": "cloudroast/blockstorage/volumes_api/integration/compute/fixtures.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 50,
|
||||
"author": {
|
||||
"id": 31955
|
||||
},
|
||||
"writtenOn": "2020-05-11T20:43:04Z",
|
||||
"side": 1,
|
||||
"message": "You don\u0027t need this (or is there something missing?) If nothing is missing, you can delete this line and you should be able to use key_name directly in the code (as you do in line 52).",
|
||||
"revId": "144dd3b3c8fa8321c7eeb37b34edc55aab404ad7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ff570b3c_39f5afcc",
|
||||
"filename": "cloudroast/blockstorage/volumes_api/integration/compute/fixtures.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 197,
|
||||
"author": {
|
||||
"id": 31955
|
||||
},
|
||||
"writtenOn": "2020-05-11T20:43:04Z",
|
||||
"side": 1,
|
||||
"message": "It is usually considered a \"bad practice\" to import libraries in the middle of code. You can put both \"from x import class\" imports at the top of the file (L: 192-7, 201-2) and then reference the imported class directly.\n\n(Was this copied from another file? It looks vaguely familiar.)",
|
||||
"revId": "144dd3b3c8fa8321c7eeb37b34edc55aab404ad7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue