x
/
deb-oslo.versionedobjects
Code Issues Proposed changes

Merge "Fix a typo in Enum error path"

This commit is contained in:
Jenkins 2016-05-19 19:55:53 +00:00 committed by Gerrit Code Review
parent 885abcb894 59ac1d009d
commit 05d98a8432
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
oslo_versionedobjects/fields.py
View File

@ -685,7 +685,7 @@ class BaseEnumField(AutoTypedField):
if not isinstance(self.AUTO_TYPE, Enum):
raise exception.EnumFieldInvalid(
typename=self.AUTO_TYPE.__class__.__name,
typename=self.AUTO_TYPE.__class__.__name__,
fieldname=self.__class__.__name__)
super(BaseEnumField, self).__init__(**kwargs)

9
oslo_versionedobjects/tests/test_fields.py
View File

@ -296,6 +296,15 @@ class TestEnum(TestField):
self.assertRaises(exception.EnumValidValuesInvalidError,
fields.EnumField, True)
def test_enum_subclass_check(self):
def _test():
class BrokenEnumField(fields.BaseEnumField):
AUTO_TYPE = int
BrokenEnumField()
self.assertRaises(exception.EnumFieldInvalid, _test)
class TestStateMachine(TestField):