From 6e952669487fa5dc886f535d13c9e8a92902835a Mon Sep 17 00:00:00 2001
From: Gerrit User 5557 <5557@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Wed, 22 May 2019 13:51:52 +0000
Subject: [PATCH] Update patch set 1

Patch Set 1: Code-Review+2

(3 comments)

Patch-set: 1
Label: Code-Review=+2
---
 5bb72719fce93a93cf79169436088012281280d7 | 67 ++++++++++++++++++++++++
 1 file changed, 67 insertions(+)
 create mode 100644 5bb72719fce93a93cf79169436088012281280d7

diff --git a/5bb72719fce93a93cf79169436088012281280d7 b/5bb72719fce93a93cf79169436088012281280d7
new file mode 100644
index 0000000..d5ed419
--- /dev/null
+++ b/5bb72719fce93a93cf79169436088012281280d7
@@ -0,0 +1,67 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "bfb3d3c7_6903d074",
+        "filename": "fixtures_git/gitfixture.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 295,
+      "author": {
+        "id": 5557
+      },
+      "writtenOn": "2019-05-22T13:51:52Z",
+      "side": 1,
+      "message": "I think a docstring would be useful here even just to note that the username/password are not used for the initial clone, even if set.",
+      "revId": "5bb72719fce93a93cf79169436088012281280d7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bfb3d3c7_8995e4e6",
+        "filename": "fixtures_git/gitfixture.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 315,
+      "author": {
+        "id": 5557
+      },
+      "writtenOn": "2019-05-22T13:51:52Z",
+      "side": 1,
+      "message": "Change to:\n\n  if self.username:\n\n?\n\n(Setting self.username to \u0027\u0027 could result in a badly-formatted auth component of the recomposed url)",
+      "range": {
+        "startLine": 315,
+        "startChar": 8,
+        "endLine": 315,
+        "endChar": 36
+      },
+      "revId": "5bb72719fce93a93cf79169436088012281280d7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bfb3d3c7_c96d1c99",
+        "filename": "fixtures_git/gitfixture.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 317,
+      "author": {
+        "id": 5557
+      },
+      "writtenOn": "2019-05-22T13:51:52Z",
+      "side": 1,
+      "message": "This seems redundant since auth, and presumably url_parts[1], will always be set.",
+      "range": {
+        "startLine": 317,
+        "startChar": 30,
+        "endLine": 317,
+        "endChar": 37
+      },
+      "revId": "5bb72719fce93a93cf79169436088012281280d7",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}
\ No newline at end of file