x
/
fixtures-git
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 1054 <1054@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 1054 2018-04-16 17:17:04 +00:00 committed by Gerrit Code Review
parent b74c3d1e5a
commit b8e725035f
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
16ba5048ecaf622512db4dd611fe8726005e63e0
View File

@ -22,6 +22,30 @@
"revId": "16ba5048ecaf622512db4dd611fe8726005e63e0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f6a8fd7_68c8d854",
"filename": "fixtures_git/__init__.py",
"patchSetId": 2
},
"lineNbr": 315,
"author": {
"id": 1054
},
"writtenOn": "2018-04-16T17:17:04Z",
"side": 1,
"message": "You can\u0027t safely re-open files for writing on certain platforms, instead you need to close and then re-open.\n\nSo to make it easy to use the \u0027with open(...) as f\u0027 syntax below, I was closing the tmp file immediately.\n\nGuess the comment isn\u0027t great, does the following work better:\n\n close immediately to ensure code for writing the file contents\n can use a common approach with using open()",
"parentUuid": "9f6a8fd7_2369a8bd",
"range": {
"startLine": 314,
"startChar": 18,
"endLine": 315,
"endChar": 41
},
"revId": "16ba5048ecaf622512db4dd611fe8726005e63e0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}