Update patch set 14

Patch Set 14:

(6 comments)

Some questions, and might be worth updating year in copyright headers, but +2 nonetheless.

Patch-set: 14
This commit is contained in:
Gerrit User 5557 2018-06-25 21:53:36 +00:00 committed by Gerrit Code Review
parent b4a5c8f355
commit e13d80d092
1 changed files with 136 additions and 0 deletions

View File

@ -0,0 +1,136 @@
{
"comments": [
{
"key": {
"uuid": "5f7c97a3_bea98f8f",
"filename": "fixtures_git/__init__.py",
"patchSetId": 14
},
"lineNbr": 1,
"author": {
"id": 5557
},
"writtenOn": "2018-06-25T21:53:36Z",
"side": 1,
"message": "Bump to 2018?",
"range": {
"startLine": 1,
"startChar": 24,
"endLine": 1,
"endChar": 26
},
"revId": "2b15b3ef3b4182bc75c80cea0d622a15cac84fd7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_fedf0709",
"filename": "fixtures_git/gitfixture.py",
"patchSetId": 14
},
"lineNbr": 95,
"author": {
"id": 5557
},
"writtenOn": "2018-06-25T21:53:36Z",
"side": 1,
"message": "Would it make sense to put this docstring on the class, as opposed to on this helper func?",
"revId": "2b15b3ef3b4182bc75c80cea0d622a15cac84fd7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1e73e34f",
"filename": "fixtures_git/gitfixture.py",
"patchSetId": 14
},
"lineNbr": 113,
"author": {
"id": 5557
},
"writtenOn": "2018-06-25T21:53:36Z",
"side": 1,
"message": "I don\u0027t understand this sentence.",
"range": {
"startLine": 112,
"startChar": 7,
"endLine": 113,
"endChar": 78
},
"revId": "2b15b3ef3b4182bc75c80cea0d622a15cac84fd7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_9ee5b3a6",
"filename": "fixtures_git/gitfixture.py",
"patchSetId": 14
},
"lineNbr": 240,
"author": {
"id": 5557
},
"writtenOn": "2018-06-25T21:53:36Z",
"side": 1,
"message": "Is there a need to have different content in each file?",
"range": {
"startLine": 240,
"startChar": 7,
"endLine": 240,
"endChar": 16
},
"revId": "2b15b3ef3b4182bc75c80cea0d622a15cac84fd7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_fe65c71d",
"filename": "fixtures_git/gitfixture.py",
"patchSetId": 14
},
"lineNbr": 276,
"author": {
"id": 5557
},
"writtenOn": "2018-06-25T21:53:36Z",
"side": 1,
"message": "Any reason not to let num be definitive?",
"range": {
"startLine": 276,
"startChar": 8,
"endLine": 276,
"endChar": 39
},
"revId": "2b15b3ef3b4182bc75c80cea0d622a15cac84fd7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1e7c43b4",
"filename": "fixtures_git/utils.py",
"patchSetId": 14
},
"lineNbr": 18,
"author": {
"id": 5557
},
"writtenOn": "2018-06-25T21:53:36Z",
"side": 1,
"message": "(Question): Why are these underscore funcs?",
"range": {
"startLine": 18,
"startChar": 4,
"endLine": 18,
"endChar": 20
},
"revId": "2b15b3ef3b4182bc75c80cea0d622a15cac84fd7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}