Update patch set 1
Patch Set 1: Code-Review-1 (2 comments) Patch-set: 1 Label: Code-Review=-1
This commit is contained in:
parent
f3b6d16d95
commit
5fe8507c01
|
@ -0,0 +1,50 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9a30ddce_e4179c42",
|
||||
"filename": "service/files/ceph.conf.j2",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 18,
|
||||
"author": {
|
||||
"id": 7710
|
||||
},
|
||||
"writtenOn": "2017-03-13T06:27:15Z",
|
||||
"side": 1,
|
||||
"message": "service_account.project?",
|
||||
"range": {
|
||||
"startLine": 18,
|
||||
"startChar": 32,
|
||||
"endLine": 18,
|
||||
"endChar": 54
|
||||
},
|
||||
"revId": "fcd20ca210196f6bfc406e43cad60f58a012782e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9a30ddce_8444204a",
|
||||
"filename": "service/files/ceph.conf.j2",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 26,
|
||||
"author": {
|
||||
"id": 7710
|
||||
},
|
||||
"writtenOn": "2017-03-13T06:27:15Z",
|
||||
"side": 1,
|
||||
"message": "if you propose to use service domain then you should create account using `service_account` parameters for auth.",
|
||||
"range": {
|
||||
"startLine": 25,
|
||||
"startChar": 0,
|
||||
"endLine": 26,
|
||||
"endChar": 59
|
||||
},
|
||||
"revId": "fcd20ca210196f6bfc406e43cad60f58a012782e",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue