Update patch set 4

Patch Set 4: (4 comments) Patch-set: 4 Label: Workflow=0
2017-01-19 09:31:24 +00:00 · 2017-01-19 09:31:24 +00:00 · 7b1d7e153e
parent d29923fc54
commit 7b1d7e153e
1 changed files with 92 additions and 0 deletions
--- a/92
+++ b/92
@ -1,5 +1,97 @@
 {
  "comments": [
+    {
+      "key": {
+        "uuid": "5a3905b3_bb3109ef",
+        "filename": "deployment_scripts/puppet/modules/opendaylight/lib/puppet/parser/functions/odl_hiera_overrides.rb",
+        "patchSetId": 4
+      },
+      "lineNbr": 6,
+      "author": {
+        "id": 8362
+      },
+      "writtenOn": "2017-01-19T09:31:24Z",
+      "side": 1,
+      "message": "It is now no longer needed",
+      "range": {
+        "startLine": 6,
+        "startChar": 4,
+        "endLine": 6,
+        "endChar": 12
+      },
+      "revId": "87d56a022a0ad95e72c3347ab2124ad0721a05b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a3905b3_3b87d910",
+        "filename": "deployment_scripts/puppet/modules/opendaylight/lib/puppet/parser/functions/odl_hiera_overrides.rb",
+        "patchSetId": 4
+      },
+      "lineNbr": 30,
+      "author": {
+        "id": 8362
+      },
+      "writtenOn": "2017-01-19T09:31:24Z",
+      "side": 1,
+      "message": "If we use native interface, this line is no needed any more.",
+      "range": {
+        "startLine": 30,
+        "startChar": 8,
+        "endLine": 30,
+        "endChar": 53
+      },
+      "revId": "87d56a022a0ad95e72c3347ab2124ad0721a05b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a3905b3_9b760d3d",
+        "filename": "deployment_scripts/puppet/modules/opendaylight/lib/puppet/parser/functions/odl_hiera_overrides.rb",
+        "patchSetId": 4
+      },
+      "lineNbr": 44,
+      "author": {
+        "id": 8362
+      },
+      "writtenOn": "2017-01-19T09:31:24Z",
+      "side": 1,
+      "message": "If we use native interface, this line is no needed any more.",
+      "range": {
+        "startLine": 44,
+        "startChar": 8,
+        "endLine": 44,
+        "endChar": 53
+      },
+      "revId": "87d56a022a0ad95e72c3347ab2124ad0721a05b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a3905b3_3b2b5932",
+        "filename": "deployment_scripts/puppet/modules/opendaylight/lib/puppet/parser/functions/odl_hiera_overrides.rb",
+        "patchSetId": 4
+      },
+      "lineNbr": 50,
+      "author": {
+        "id": 8362
+      },
+      "writtenOn": "2017-01-19T09:31:24Z",
+      "side": 1,
+      "message": "I\u0027m not sure about that. My understanding is that this variable tell neutron agents where ovsdb server listen for request. Here you are pointing to ovsdb manager in opendaylight. I thought that you may want to set this to listen on different port than 6640, so on the end you will have 2 mangers set for ovs:\n- one for neutron agents, listen in passive mode (listen for ex on port 6639)\n- second pointing to opendaylight (active, listen on port 6640)",
+      "range": {
+        "startLine": 50,
+        "startChar": 7,
+        "endLine": 50,
+        "endChar": 66
+      },
+      "revId": "87d56a022a0ad95e72c3347ab2124ad0721a05b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
    {
      "key": {
        "uuid": "5a3905b3_009f0b04",